feat(docker): collect tool LICENSE files into install dir#4250
Open
luarss wants to merge 2 commits into
Open
Conversation
Copy LICENSE files from tool source trees into tools/install/licenses/ so they are included in the final image. Excludes tools/OpenROAD/src/sta. Fixes: https://github.com/The-OpenROAD-Project/AutoTuner/issues/146 Signed-off-by: Jack Luar <jluar@precisioninno.com>
6c3efaf to
de23328
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the .dockerignore file to exclude build directories for OpenROAD, yosys-slang, and kepler-formal. It also modifies the Dockerfile.builder to automate the collection of license files from the tools source tree into the installation directory, while excluding specific paths. Feedback was provided to improve the robustness of the license collection script by excluding the destination directory from the search and using IFS= read -r to handle potential spaces in file paths.
Prevent find from re-discovering already-copied license files in the install destination, and handle paths with spaces correctly. Signed-off-by: Jack Luar <jluar@precisioninno.com>
d36de44 to
c1c6770
Compare
Member
|
Are you include those from OpenROAD? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy LICENSE files from tool source trees into tools/install/licenses/ so they are included in the final image. Excludes tools/OpenROAD/src/sta.
Fixes: https://github.com/The-OpenROAD-Project/AutoTuner/issues/146
Repro:
Output: