Skip to content

removed trailing slash since rapidus2hp can be a symlink#4226

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:rapidus-gitignore
May 12, 2026
Merged

removed trailing slash since rapidus2hp can be a symlink#4226
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:rapidus-gitignore

Conversation

@jeffng-or
Copy link
Copy Markdown
Contributor

No description provided.

@jeffng-or jeffng-or self-assigned this May 12, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .gitignore file in flow/designs/ to correctly ignore the rapidus2hp symlink by removing the trailing slash. The review feedback suggests anchoring the pattern with a leading slash to prevent accidental ignores in subdirectories and provides a technical correction regarding Git's handling of symlinks in ignore patterns.

Comment thread flow/designs/.gitignore Outdated
Comment on lines +1 to +2
# rapidus2hp can't have a trailing slash since it's a symlink and not a directory
rapidus2hp
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pattern rapidus2hp without a leading slash matches any file or directory with that name at any depth within the flow/designs/ directory tree. To prevent accidental ignores of files or directories named rapidus2hp in subdirectories (e.g., under a specific platform), it is better to anchor the pattern to the directory containing the .gitignore file using a leading slash.

Furthermore, the comment can be improved for technical accuracy: git treats symlinks as files in its index, and a trailing slash in a .gitignore pattern specifically restricts the match to directories, which is why it fails to match a symlink even if it points to a directory.

# Ignore the rapidus2hp symlink (leading slash anchors to this directory, no trailing slash to match symlink)
/rapidus2hp

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

updates

Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
@jeffng-or jeffng-or requested a review from maliberty May 12, 2026 18:53
@maliberty maliberty enabled auto-merge May 12, 2026 19:00
@maliberty maliberty merged commit 09ba6c0 into The-OpenROAD-Project:master May 12, 2026
7 of 8 checks passed
@maliberty maliberty deleted the rapidus-gitignore branch May 12, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants