removed trailing slash since rapidus2hp can be a symlink#4226
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the .gitignore file in flow/designs/ to correctly ignore the rapidus2hp symlink by removing the trailing slash. The review feedback suggests anchoring the pattern with a leading slash to prevent accidental ignores in subdirectories and provides a technical correction regarding Git's handling of symlinks in ignore patterns.
| # rapidus2hp can't have a trailing slash since it's a symlink and not a directory | ||
| rapidus2hp |
There was a problem hiding this comment.
The pattern rapidus2hp without a leading slash matches any file or directory with that name at any depth within the flow/designs/ directory tree. To prevent accidental ignores of files or directories named rapidus2hp in subdirectories (e.g., under a specific platform), it is better to anchor the pattern to the directory containing the .gitignore file using a leading slash.
Furthermore, the comment can be improved for technical accuracy: git treats symlinks as files in its index, and a trailing slash in a .gitignore pattern specifically restricts the match to directories, which is why it fails to match a symlink even if it points to a directory.
# Ignore the rapidus2hp symlink (leading slash anchors to this directory, no trailing slash to match symlink)
/rapidus2hp
updates Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
3bf5f6d to
1db1653
Compare
No description provided.