Skip to content

Correct the WITH_VERIFIC_CHECK in the build_openroad.sh docker build. #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 2 commits into from
May 10, 2026
+4 −4
Merged

Correct the WITH_VERIFIC_CHECK in the build_openroad.sh docker build. #4221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5f4858
Correct the WITH_VERIFIC_CHECK in the build_openroad.sh docker build.
maliberty May 10, 2026
04fd4f7
Fix empty-options arg regression in build_openroad.sh docker build.
maliberty May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions build_openroad.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,13 +237,13 @@ __docker_build()
cp .dockerignore{,.bak}
sed -i '/flow\/platforms/d' .dockerignore
fi
options=""
if [ -n "${WITH_VERIFIC}" ]; then
local options=()
if [ "${WITH_VERIFIC}" -eq 1 ]; then
cp -r "${VERIFIC_SRC}" tools/verific
options="-buildArgs=--build-arg verificPath=tools/verific"
options=("-buildArgs=--build-arg verificPath=tools/verific")
fi
./etc/DockerHelper.sh create -target=dev -os="${DOCKER_OS_NAME}" -threads="${PROC}"
./etc/DockerHelper.sh create -target=builder -os="${DOCKER_OS_NAME}" -threads="${PROC}" "${options}"
./etc/DockerHelper.sh create -target=builder -os="${DOCKER_OS_NAME}" -threads="${PROC}" "${options[@]}"
rm -rf tools/verific
if [ ! -z "${DOCKER_COPY_PLATFORMS+x}" ]; then
mv .dockerignore{.bak,}
Expand Down