-
Notifications
You must be signed in to change notification settings - Fork 1
Chat backend+Frontend added #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: backend-development
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # src/app/page.tsx # src/app/room/[slug]/layout.tsx # src/app/room/[slug]/page.tsx # src/ui/navbar.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dongjin2008 Remove all changes here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dongjin2008 Remove all changes here
package.json
Outdated
| "clsx": "^2.0.0", | ||
| "convex": "^1.2.1", | ||
| "next": "^13.4.2", | ||
| "dotenv": "^16.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this dependency
src/app/ConvexClientProvider.tsx
Outdated
| import { ConvexProvider, ConvexReactClient } from "convex/react"; | ||
| import * as process from "process"; | ||
|
|
||
| const convex = new ConvexReactClient(process.env.NEXT_PUBLIC_CONVEX_URL!); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls. use the ~/env.mjs file not dotenv!!! no process.env!
src/app/room/[slug]/layout.tsx
Outdated
| const snap = useSnapshot(state); | ||
| return ( | ||
| <section className="h-screen px-10 py-14 flex flex-col"> | ||
| <Navbar> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need the navbar component? Pls. remove the navbar component and put the logic into this file. Or you have a good reason to do it.
src/ui/navbar.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file and put the navbar into the layout. Or you have a good reason to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this file to profile.tsx
src/app/room/[slug]/layout.tsx
Outdated
| <section className="h-screen px-10 py-14 flex flex-col"> | ||
| <Navbar> | ||
| <Profile type="nav" initial={snap.user.charAt(0).toUpperCase()} /> | ||
| <Profile type="nav" initial={snap.user.charAt(0).toUpperCase()} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls. make them into buttons! Use the ~/ui/button for that
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: prettier@2.8.8 |
# Conflicts: # package.json # pnpm-lock.yaml # src/app/layout.tsx
No description provided.