Check max complexity before bool process #1786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test models have 500 nested boolean operations, which blocks the processing indefinitely. A max number of boolean operations is not very helpful, since the meshes could be simple or complicated. A max number of faces in the operands works quite well. Also, improve ComputeInitialIntersections with AI. A test model got stuck. With the changes, it works.
Some test models have 500 nested boolean operations, which blocks the processing indefinitely. A max number of boolean operations is not very helpful, since the meshes could be simple or complicated. A max number of faces in the operands works quite well. Also, improve ComputeInitialIntersections with AI. A test model got stuck. With the changes, it works.
> npm install > npm run build-release > npm run regression > npm run regression-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a test model with 500 nested boolean operations, which leads to literally infinite processing time, because it gets more complex and slower every time.
The mesh is not that complicated, just a grid of 20x25 openings in a slab:
Some openings are missing, due to the cap at a max number of faces, which this PR suggests.
But the missing openings are much better than infinite loading times.
In BimVision it looks like this:
So there is obviously also a similar fail-safe implemented there.