Skip to content

fix(getShellData): bbox + raw shell not respecting settings.precision#212

Merged
agviegas merged 2 commits into
ThatOpen:mainfrom
ShaMan123:fix/bbox-precision
May 29, 2026
Merged

fix(getShellData): bbox + raw shell not respecting settings.precision#212
agviegas merged 2 commits into
ThatOpen:mainfrom
ShaMan123:fix/bbox-precision

Conversation

@ShaMan123
Copy link
Copy Markdown
Contributor

@ShaMan123 ShaMan123 commented May 14, 2026

Description

fixes #211

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ShaMan123 ShaMan123 changed the title Fix/bbox precision fix(getShellData): bbox + raw shell respecting settings.precision May 14, 2026
Copy link
Copy Markdown
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

@ShaMan123 ShaMan123 changed the title fix(getShellData): bbox + raw shell respecting settings.precision fix(getShellData): bbox + raw shell not respecting settings.precision May 14, 2026
@ShaMan123
Copy link
Copy Markdown
Contributor Author

I want to fix GeometryProcessSettings type not including its comments in index.d.ts but don't know how to

@ShaMan123 ShaMan123 force-pushed the fix/bbox-precision branch from 27b3a81 to 2ae1046 Compare May 14, 2026 08:11
@agviegas agviegas merged commit 6c67266 into ThatOpen:main May 29, 2026
@agviegas
Copy link
Copy Markdown
Contributor

The comments don't make it into index.d.ts because they're written as /* */ and // comments. TypeScript's declaration emit only keeps JSDoc /** */ comments. Switching each one above the GeometryProcessSettings members to /** */ will make them show up in dist/index.d.ts. No build config change needed.

@ShaMan123
Copy link
Copy Markdown
Contributor Author

I really wanted to add some tests to validate this change but was a bit discouraged since there is no test framework.

@ShaMan123 ShaMan123 deleted the fix/bbox-precision branch May 29, 2026 13:57
@agviegas
Copy link
Copy Markdown
Contributor

Totally fair, that's on us. There's a half-wired jest setup but no real harness, and we've settled on moving to vitest (see the #197 thread). I'll get a minimal vitest config landed so fixes like this can ship with a test. This one's solid and already merged, so don't worry about it. Thanks for pushing, and the JSDoc tip is handled now in #226.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply GeometryProcessSettings.precision on position?

2 participants