feat(materials): add depthWrite property to MaterialDefinition #145
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidi29
added a commit
to maidi29/engine_fragment
that referenced
this pull request
Jan 14, 2026
…ation - Add depthWrite property to MaterialDefinition (from PR ThatOpen#145) - Update MaterialUtils.isSame to include transparent, depthTest, depthWrite - Remove blanket dedup-disable for preserveOriginalMaterial - Merge base material properties in highlight-helper before deduplication - Add depthTest and depthWrite to highlight props list Items with the same base material properties (opacity, transparent, depthTest, depthWrite, renderedFaces) and same highlight color now share a single material, dramatically reducing material count while preserving per-item opacity. Example: 1000 windows with opacity=0.5 colored red -> 1 material instead of 1000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for controlling depth buffer writes in material definitions. The new
depthWriteproperty allows developers to specify whether a material should write to the depth buffer during rendering.This is particularly useful for transparent objects that shouldn't occlude other geometry behind them. When
depthWriteis set tofalse, transparent materials can render correctly without blocking objects that should be visible through them.Changes:
depthWrite?: booleanproperty toMaterialDefinitiontype with default value oftruedepthWritehandling inMaterialManagerwhen creating materials (defaults totrueif not specified)depthWritesupport in highlight definition merging logicdepthTestanddepthWriteAdditional context
This feature complements the existing
depthTestproperty and provides finer control over depth buffer operations.Files modified:
packages/fragments/src/FragmentsModels/src/model/material-manager.tspackages/fragments/src/FragmentsModels/src/model/model-types.tsWhat is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).