test(playwright): cover browser flows with typed harness#1076
Draft
ThatGuySam wants to merge 2 commits intomasterfrom
Draft
test(playwright): cover browser flows with typed harness#1076ThatGuySam wants to merge 2 commits intomasterfrom
ThatGuySam wants to merge 2 commits intomasterfrom
Conversation
Lock the Apple Silicon upload flow behind a real browser regression and migrate the Pagefind browser regression onto a shared typed harness. This keeps the branch non-runtime and repairs the targeted pagefind script alias after moving the browser test to TypeScript. Constraint: Must avoid runtime code changes on this branch Rejected: Ship the app-test coverage without fixing script aliases | leaves a broken targeted check in package.json Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep browser-only support helpers under test/playwright/support until runtime code is typed separately Tested: pnpm run typecheck; pnpm run test:browser; pnpm run test:browser:pagefind Not-tested: pnpm run test:browser:pagefind:live
Record the staged approach for locking the Apple Silicon scan flow with browser coverage before moving deeper into the TypeScript conversion. Keeping this plan separate from the test commit preserves a clean non-runtime history. Constraint: Plan should not change runtime behavior or blur code-review scope Rejected: Fold the plan into the browser-test commit | mixes delivery guidance with executable changes Confidence: high Scope-risk: narrow Reversibility: clean Directive: Revisit the worker-based scanner path only after the legacy app-test route has stable browser coverage Tested: Document reviewed against current staged test coverage and repo layout Not-tested: Plan execution beyond the committed browser-test slice
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Notes