WipeCharacterTable/WipeGuildTable: skip non-table inputs#11
Open
kilick wants to merge 1 commit into
Open
Conversation
ClearAllData and DeleteGuild iterate registered modules and pass moduleDB.Characters / .Guilds to WipeCharacterTable / WipeGuildTable. For some modules these references resolve to a function (via the DataStore method metatable), which then crashes pairs() with 'bad argument Thaoky#1 to pairs (table expected, got function)'. Use a type check instead of a truthiness check so non-table inputs are silently skipped, matching the original intent for missing keys. Fixes Altoholic_Retail#33.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking Wipe Database in the Altoholic Summary crashes with
bad argument #1 to 'pairs' (table expected, got function)fromDataStore.lua:382.ClearAllDataiterates the registered modules and passesmoduleDB.Characters/.Guildsinto the wipe helpers. For some modules these resolve to a function (via the DataStore method metatable), so the existingif not t then return endguard passes through andpairs(t)then errors.Using a
type(t) ~= "table"check instead lets non-table values fall through silently, which matches the original intent for "no character table on this module."Fixes Thaoky/Altoholic_Retail#33.