Skip to content

Conversation

@keiji
Copy link

@keiji keiji commented Aug 24, 2024

This Pull Request brings several key improvements to the project:

Modernization & Compatibility

Updated the entire project to build seamlessly with the latest Android Studio version, ensuring a smooth development experience.

Update minSdkVersion to 21 to support NDK 27 requirement.

Added support for 16kb page sizes, a feature planned for introduction in Android 15 and later, enhancing future compatibility and potential performance gains.
https://developer.android.com/guide/practices/page-sizes

Instead of including OpenJPEG directly in the source tree, I've set it up to sync as a Git submodule. This clarifies exactly which commit of the OpenJPEG project is being used and should make it easier to incorporate updates.

Maven Central Publication

Adjusted the maven-publish plugin configuration to enable seamless publication of the library on Maven Central, making it easily accessible to developers.

These changes modernize the project, improve compatibility with upcoming Android versions, and streamline the process of sharing the library with the wider development community.

keiji added 12 commits August 24, 2024 21:16
- Updated Gradle to version 8.7
- Updated Android compile and target SDK to
 34
- Updated NDK version to 23.0.7344513
- Updated CMake version to 3.22.1
- Removed Bintray publishing configuration
- Refactored CMakeLists.txt to use modern CMake practices
- Updated AndroidManifest.
xml to meet modern Android requirements
- Upgraded androidx.annotation to 1.8.2
- Upgraded androidx.test.ext:junit to
1.2.1
- Upgraded androidx.test.espresso:espresso-core to 3.6.1
- Added metadata to the Maven publication, including project description, URL, license, developer information, and SCM details.
- Ensured that the publication process depends on the assemble task.
- Updated group ID to 'dev.keiji.jp2'.
- Updated project description and URLs to reflect the fork.
-
 Added maintainer information.
Added ARIYAMA Keiji to copyright notice in LICENSE.
@keiji
Copy link
Author

keiji commented Aug 26, 2024

Thank you for developing the Android bindings. I have published the binaries based on this Pull Request to Maven Central.
https://central.sonatype.com/artifact/dev.keiji.jp2/jp2-android

Please let me know if you plan to continue development on this project. I would be happy to see the projects merged and contribute to it in that case.

@Holoceo
Copy link

Holoceo commented Oct 5, 2024

@keiji legend! Thank you!

@keiji
Copy link
Author

keiji commented Jan 4, 2026

I fixed the PR as it was broken due to a mistake during the upstream merge.
For now, I've confirmed that the library builds with OpenJPEG 2.5.2 and 16KB page size support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants