Migrate to axum by lajp · Pull Request #115 · Testaustime/testaustime-backend

lajp · 2025-10-24T07:37:23Z

No description provided.

also implement max_registers_per_hour

also remove all instances of impl IntoResponse in endpoint types

also thank you utoipa

Eldemarkki · 2025-12-12T14:49:51Z

settings.toml.example is missing the new email fields

src/main.rs

Eldemarkki · 2025-12-12T15:01:01Z

Secured access mentions should be removed from error.rs and APISPEC.md

Eldemarkki · 2025-12-12T20:21:05Z

The APISPEC seems to be out of date in general, for example it still has /auth/changepassword endpoint. Maybe the file is not needed now that we have OpenAPI, we could move the descriptions there?

DrVilepis · 2025-12-12T21:27:15Z

The plan is to completely remove the apispec in favor of openapi. Also I doubt that the apispec is even 50% correct

this was done in favor of the new openapi docs

src/api/leaderboards.rs

DrVilepis

My preliminary approval now that the pr is starting to be in its final state.

most notably argon2

lajp

This looks almost good to go! I mostly complained about unwrap()s but there's some other comments as well. I did not review tests.

lajp · 2026-01-31T21:19:35Z

src/api/auth.rs

-    type Error = TimeError;
-    type Future = Pin<Box<dyn Future<Output = actix_web::Result<Self, Self::Error>>>>;
+    async fn from_request_parts(parts: &mut Parts, _: &S) -> Result<Self, Self::Rejection> {
+        let auth = parts.extensions.get::<Authentication>().cloned().unwrap();


Should this be a Self::Rejection instead of unwrap

lajp · 2026-01-31T21:20:00Z

src/api/auth.rs

-    type Error = TimeError;
-    type Future = Pin<Box<dyn Future<Output = actix_web::Result<Self, Self::Error>>>>;
+    async fn from_request_parts(parts: &mut Parts, _state: &S) -> Result<Self, Self::Rejection> {
+        let auth = parts.extensions.get::<Authentication>().cloned().unwrap();


This probably also shouldn't panic

lajp · 2026-01-31T21:20:16Z

src/api/auth.rs

+    type Rejection = TimeError;
+
+    async fn from_request_parts(parts: &mut Parts, _: &S) -> Result<Self, Self::Rejection> {
+        let auth = parts.extensions.get::<Authentication>().cloned().unwrap();


don't panic here either

lajp · 2026-01-31T21:22:51Z

src/api/auth.rs

+
+    let token = generate_password_reset_token();
+
+    let message = Message::builder()


convert these unwraps to .expect("BUG: <description>") if they are truly infallible

lajp · 2026-01-31T21:25:58Z

src/api/mod.rs

-    pub static REGEX: Regex = Regex::new("^[[:word:]]{2,32}$").unwrap();
-}
+pub static VALID_NAME_REGEX: LazyLock<Regex> =
+    LazyLock::new(|| Regex::new("^[[:word:]]{2,32}$").unwrap());


change this to .expect("BUG: failed to compile name regex") or something like that

lajp · 2026-01-31T21:46:29Z

src/models.rs

+}
+
+// Wtf is this
+fn project_deserialize<'de, D>(deserializer: D) -> Result<Option<String>, D::Error>


should probably be removed :D

lajp · 2026-01-31T21:47:31Z

src/ratelimiter.rs

+            let conn_info = req
+                .extensions()
+                .get::<ConnectInfo<SocketAddr>>()
+                .unwrap()


.expect("BUG: connection info is always available")

lajp · 2026-01-31T21:48:07Z

src/ratelimiter.rs

                        headers.insert(
                            HeaderName::from_static("ratelimit-limit"),
-                            HeaderValue::from_str(&quota.burst_size().to_string())?,
+                            HeaderValue::from_str(&quota.burst_size().to_string()).unwrap(),


please .expect all header value creations

lajp · 2026-01-31T21:48:22Z

src/ratelimiter.rs

-                    Ok(req.into_response(response.map_into_right_body()))
+                        )
+                        .body(Body::empty())
+                        .unwrap())


lajp · 2026-01-31T21:48:29Z

src/ratelimiter.rs

+                Ok(Response::builder()
+                    .status(StatusCode::INTERNAL_SERVER_ERROR)
+                    .body(Body::empty())
+                    .unwrap())


DrVilepis and others added 8 commits April 16, 2025 10:58

migrate to axum

5c7fb67

fix tests

80d1406

use hyphens in endpoints

40a15f9

use register middleware for register

66278f0

also implement max_registers_per_hour

cleanup and errors

4d1a12f

make activity endpoints use json

8cb1b89

feat: add nix flake

964df23

chore(ci): improve nix build and use it in docker build

f38b396

lajp requested a review from DrVilepis as a code owner October 24, 2025 07:37

lajp and others added 6 commits October 24, 2025 09:39

chore: fmt

ba8d79d

unimplement secured access

2de393d

fmt, clippy and tests

bd914db

tests

61493a4

openapi via utoipa

216ade6

also remove all instances of impl IntoResponse in endpoint types

I forgot we have tests

801e38d

also thank you utoipa

Eldemarkki reviewed Dec 12, 2025

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

This was referenced Dec 12, 2025

Collect email address optionally for resetting password #90

Open

Fix changes for axum rewrite and refactor request handling Testaustime/testaustime-frontend#488

Open

Copilot AI mentioned this pull request Dec 13, 2025

Verify endpoint consistency with backend Axum rewrite PR Testaustime/testaustime-frontend#489

Closed

DrVilepis added 5 commits December 13, 2025 15:32

add email fields to example

6411d46

typo

e9ec351

add back token regeneration

2cd3e04

small fixes

a981ed4

removed markdown apispec

53ed1c6

this was done in favor of the new openapi docs

Eldemarkki reviewed Dec 13, 2025

View reviewed changes

src/api/leaderboards.rs Outdated Show resolved Hide resolved

typo #2

a1ad0b0

lajp force-pushed the axum branch from c19dd6d to 4bef60f Compare December 15, 2025 12:54

chore: use nix in the entire CI, formatting and clippy fixes

1dc67c1

lajp force-pushed the axum branch from 4bef60f to 1dc67c1 Compare December 15, 2025 13:09

DrVilepis previously approved these changes Dec 17, 2025

View reviewed changes

do not store 0s activities

c9bf869

DrVilepis dismissed their stale review via c9bf869 January 8, 2026 07:58

DrVilepis added 4 commits January 13, 2026 12:21

increase all heartbeat limits to 64 chars

c526d98

fix tests

fd12e8d

bump deps and update code

6476521

most notably argon2

fmt

910b1d1

Eldemarkki mentioned this pull request Jan 18, 2026

/auth/changepassword doesn't require secure access token #98

Open

fix: fmt

0a8e34a

lajp commented Jan 31, 2026

View reviewed changes

lajp and others added 3 commits January 31, 2026 23:06

docs: vastly improve api documentation

0d782e9

remove unwraps and implement phc strings

7580bad

forgot to commit migrations

ebf06d4


		let token = generate_password_reset_token();

		let message = Message::builder()

Conversation

lajp commented Oct 24, 2025

Uh oh!

Eldemarkki commented Dec 12, 2025

Uh oh!

Uh oh!

Eldemarkki commented Dec 12, 2025

Uh oh!

Eldemarkki commented Dec 12, 2025

Uh oh!

DrVilepis commented Dec 12, 2025

Uh oh!

Uh oh!

DrVilepis left a comment

Choose a reason for hiding this comment

Uh oh!

lajp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants