fix: correct typo arrya to array in getPlatforms cast (line 3557)#407
Open
rudidierar wants to merge 1 commit intoTestLinkOpenSourceTRMS:testlink_1_9_20_fixedfrom
Open
fix: correct typo arrya to array in getPlatforms cast (line 3557)#407rudidierar wants to merge 1 commit intoTestLinkOpenSourceTRMS:testlink_1_9_20_fixedfrom
rudidierar wants to merge 1 commit intoTestLinkOpenSourceTRMS:testlink_1_9_20_fixedfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a PHP parse error in the XML-RPC API implementation by correcting an invalid type cast in addTestCaseToTestPlan(), restoring availability of the XML-RPC endpoint.
Changes:
- Replace mistyped
(arrya)cast with the valid(array)cast when retrieving platforms for a test plan.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Description
Problem
A typo in 'lib/api/xmlrpc/v1/xmlrpc.class.php' at line 3557 causes a PHP parse error that makes the entire
XML-RPC API unavailable.
Error in Apache logs:**
'PHP Parse error: syntax error, unexpected '$this' (T_VARIABLE) in xmlrpc.class.php o line 3557'
Impact
This single typo makes the XML-RPC API return HTTP 500 for all requests, completely breaking any external
integration (pytest, CI/CD pipelines, etc...)
Tested on
-Testlink version: 1.9.20 [fixed]
-PHP 7.x / Apache 2.4.58 on Ubuntu