CI: install yarn like TerriaJS #680
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copies the more recent CI-setup from TerriaJS, which eliminates the need to keep a copy of an old version of yarn in the repository. This eliminates a lot of warnings when doing a project scan for problems in WebStorm.
Contributor
Author
|
This repository never seems to run the CI until one of you approve it. Can the CI settings be changed so I can make the PR green before you have to look at it? |
Collaborator
|
IMO it is not a good idea to remove those files from the repo as those enforce the yarn version that works properly with terriajs codebase. We would first need to support the latest version of yarn before removing those files. |
Contributor
Author
|
This PR mirrors how it is already done in the terriajs repository. (And we're in trouble if any terria-packages will only work if they are installed with an ancient yarn that nobody uses.) |
Contributor
Author
|
Update to Yarn V2 in #728 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the more recent CI-setup
from TerriaJS, which eliminates
the need to keep a copy of an old
version of yarn in the repository.
This eliminates a lot of warnings
when doing a project scan for problems
in WebStorm.
Edit: problems detected by WebStorm with default settings before/after: 629 errors, 4819 warnings, 14459 weak warnings vs 628 errors, 593 warnings, 1018 weak warnings. The scan time also goes from taking minutes on my desktop machine to passing in a few seconds.