Open
Conversation
Contributor
|
@ryancausey thank you (I think?) for the PR. It's currently failing tests (our test ci/cd pipeline is all behind a firewall :( ). There are tests failing that have 'firmware' in the name of the test, and there's still one test that has firmare in the name: |
ryancausey
force-pushed
the
bugfix/where-dreams-go-to-die
branch
from
9fba0d6 to
cfcf667
Compare
bsanders
force-pushed
the
bugfix/where-dreams-go-to-die
branch
from
cfcf667 to
abced2a
Compare
Contributor
|
I cut out the last of it. Rebase down to one commit and I'll merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't seem to be used anywhere.