FEATURE: ReportSys test for SLES pallet patch#825
Open
Conversation
megkido
commented
Aug 25, 2020
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
bsanders
suggested changes
Aug 25, 2020
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
megkido
commented
Aug 27, 2020
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Show resolved
Hide resolved
8d88199 to
76c8041
Compare
bsanders
reviewed
Sep 1, 2020
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
9d66b6e to
6c8fea4
Compare
caladd
suggested changes
Sep 16, 2020
Contributor
caladd
left a comment
There was a problem hiding this comment.
Please make the recommended code changes and re-examine the code logic. I'm not sure this is actually testing that all the files in all the RPMs have the correct hashes.
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
| assert sles_flavors | ||
|
|
||
| # Find out where is stack-sles*images*.rpm file(s) | ||
| result = host.run('find /export/stack/pallets/stacki/ -name "*stack-sles-*.rpm"') |
Contributor
There was a problem hiding this comment.
The pattern should have a \ before the .:
"*stack-sles-*\.rpm"
Author
There was a problem hiding this comment.
having \ before . broke the code.
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Show resolved
Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated
Show resolved
Hide resolved
Author
|
Updated output Failure case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output