Conversation
teradatalabs/mapr52-base/Dockerfile
Outdated
| && yum install -y mapr-fileserver mapr-nfs mapr-nodemanager mapr-cldb \ | ||
| && yum install -y mapr-zookeeper mapr-resourcemanager mapr-historyserver \ | ||
| && yum install -y mapr-webserver mapr-gateway \ | ||
| && yum install -y mapr-webserver mapr-gateway mapr-httpfs \ |
There was a problem hiding this comment.
Add why this is needed in the commit message.
There was a problem hiding this comment.
I am removing this commit since @AS186170 has already included it in mapr-52 base.
sanjay990
force-pushed
the
mapr52-maprclient
branch
from
cca1c20 to
ff0e6bd
Compare
| @@ -0,0 +1,9 @@ | |||
| # mapr52-base | |||
There was a problem hiding this comment.
also, the heading should be the image name
There was a problem hiding this comment.
also, name the image mapr-client
| MAINTAINER Teradata Docker Team <docker@teradata.com> | ||
|
|
||
| ADD files/maprtech.repo /etc/yum.repos.d/maprtech.repo | ||
| RUN yum update -y \ |
There was a problem hiding this comment.
add entrypoint and command so that the image can be used like a standalone program
https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#entrypoint
There was a problem hiding this comment.
I don't think there's a default set of command that needs to be executed for this container.
The first step is to configure the client - https://github.com/Teradata/presto/pull/528/files#diff-d5fa118c169436bb50bbd774dc84d440R51
And this needs to be done only once, not every time you log into the container.
I can have CMD as bash, but it currently works without that.
mapr-client $docker run -it mapr-client
[root@aec1a9c03a4c /]#
So not sure if we need ENTRYPOINT/CMD
There was a problem hiding this comment.
Nevermind :) our slack conversation and your comment above have showed me that there's no point in having the entrypoint/cmd
|
please consult @petroav on licensing of mapr products and our resdistribution of them in docker images |
3 participants
No description provided.