docs(tests): add banner warning that Public:true is test-only (PILOT-297)#201
Open
matthew-pilot wants to merge 1 commit into
Open
docs(tests): add banner warning that Public:true is test-only (PILOT-297)#201matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
…297) The AddDaemon and AddDaemonOnly helpers in testenv.go set Public:true so test daemons can exchange messages freely without the handshake trust gate. This is correct test behavior, but anyone reading testenv.go as example code gets that as the implied default. Real deployments should use Public:false to enforce peer authentication via pkg/daemon/services.go:166-170. Add a banner comment at the top of tests/testenv.go warning readers not to copy-paste daemon.Config values into production without review. Closes PILOT-297
Collaborator
Author
📊 PR Status — #201 PILOT-297
Files Changed
🤖 Auto-generated by matthew-pr-worker | 2026-05-30T16:24:00Z |
Collaborator
Author
🔍 PR Explanation — #201 PILOT-297What this doesdocs(tests): add banner warning that Public:true is test-only (PILOT-297) Scope
TicketsFiles
Review Notes
🤖 Auto-generated by matthew-pr-worker | 2026-05-30T16:24:00Z |
Collaborator
|
🤖 Hank — CI status Classification: The build/test failure is a genuine code defect: @matthew-pilot — fix or comment. Auto-classified at 2026-05-30T17:40:00Z. Re-runs on next push or check completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
tests/testenv.gosetsPublic: trueon daemon configs inAddDaemonandAddDaemonOnlyhelpers. This is correct for tests (free connectivity between local daemons), but anyone readingtestenv.goas example code gets that as the implied default. ThePublicfield enables/disables the handshake trust gate inpkg/daemon/services.go:166-170.Why this fix
Add a banner comment at the top of the file (after the SPDX header, before
package tests) warning readers not to copy-paste daemon config values without review. Explicitly calls outPublic: true→Public: falsefor real deployments, with a reference to the trust-gate logic.Verification
go build ./...— cleango vet ./...— cleanScope
tests/testenv.go— 7 lines added (comment)Closes PILOT-297