Skip to content

fix(tests): generate random TestAdminToken per run instead of hardcoded secret (PILOT-296) #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthew-pilot wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

fix(tests): generate random TestAdminToken per run instead of hardcoded secret (PILOT-296) #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion tests/testenv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ package tests

import (
"context"
crand "crypto/rand"
"encoding/base64"
"encoding/hex"
"fmt"
"net"
"os"
Expand Down Expand Up @@ -50,7 +52,17 @@ func resolveLocalAddr(addr net.Addr) string {
}

// TestAdminToken is the admin token used in tests for network creation.
const TestAdminToken = "test-admin-secret"
// Generated randomly at init time so that a test environment accidentally
// deployed against staging/production won't share a predictable secret.
var TestAdminToken string

func init() {
b := make([]byte, 32)
if _, err := crand.Read(b); err != nil {
panic("failed to generate random admin token: " + err.Error())
}
TestAdminToken = "sk-test-" + hex.EncodeToString(b)
}

// TestEnv manages a complete Pilot Protocol test environment with
// OS-assigned ports and proper readiness signaling (no time.Sleep).
Expand Down
Loading