Skip to content

fix: add --no-same-owner --no-same-permissions to tar extraction (PILOT-272) #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthew-pilot wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

fix: add --no-same-owner --no-same-permissions to tar extraction (PILOT-272) #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,11 +266,18 @@ if [ -n "$TAG" ]; then
[ -n "$ACTUAL" ] && echo " Verified SHA-256"
fi
fi
# GNU tar preserves ownership and permissions from the archive by
# default (including setuid/setgid bits). BSD tar ignores ownership
# without root, so these flags are only needed on GNU tar.
TAR_SAFE=""
if tar --version 2>/dev/null | grep -q 'GNU tar'; then
TAR_SAFE="--no-same-owner --no-same-permissions"
fi
# macOS bsdtar can fail silently on GitHub gzip archives.
# Try tar -xzf first; fall back to gunzip|tar on failure.
if ! tar -xzf "$TMPDIR/$ARCHIVE" -C "$TMPDIR" 2>/dev/null || [ ! -f "$TMPDIR/pilotctl" ]; then
if ! tar -xzf "$TMPDIR/$ARCHIVE" -C "$TMPDIR" $TAR_SAFE 2>/dev/null || [ ! -f "$TMPDIR/pilotctl" ]; then
echo " tar -xzf failed or produced no output; trying gunzip fallback..."
gunzip -c "$TMPDIR/$ARCHIVE" | tar -x -C "$TMPDIR"
gunzip -c "$TMPDIR/$ARCHIVE" | tar -x $TAR_SAFE -C "$TMPDIR"
fi
if [ ! -f "$TMPDIR/pilotctl" ]; then
echo "Error: failed to extract binaries from ${ARCHIVE}"
Expand Down
Loading