Restore Next to being the useful primary development branch by jkrrv · Pull Request #226 · TenthPres/TouchPoint-WP

jkrrv · 2025-04-08T16:28:02Z

No description provided.

@SInCE

Correcting some @SInCE tags

…situations (closes #179). Also, improve error handling for script updates.

…ime.

…ments.

…king) when it shouldn't have.

…oses #220.

…ons. Closes #229

…to smaller chunks.

…ctly.

…le. They are not, at least not currently.

Copilot

Pull request overview

This PR bumps the plugin to 0.0.97 and introduces a set of changes aimed at making the “Next” branch a viable primary development line by adding Gutenberg block support, expanding/adjusting API & lookup behavior, and refactoring UI rendering for notable attributes and action buttons.

Changes:

Adds a BlocksController plus new People List and Involvement List Gutenberg blocks and supporting build pipeline updates.
Introduces/adjusts lookup + admin endpoints, caching behavior, and settings initialization/translation timing.
Refactors notable-attributes rendering and action button interfaces across content types; multiple template/CSS/JS updates.

Reviewed changes

Copilot reviewed 71 out of 83 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
wpml-config.xml	WPML config additions (types/fields/shortcodes).
touchpoint-wp.php	Version bump + new requires (Lookup/Blocks/Stats/etc).
src/TouchPoint-WP/Utilities/Translation.php	Adds helper to set WPML language by campus.
src/TouchPoint-WP/Utilities/StringableArray.php	Refactors join behavior; adds helpers.
src/TouchPoint-WP/Utilities/NotableAttributes.php	New string-join wrapper for meta badges.
src/TouchPoint-WP/Utilities/ImageConversions.php	Adds IDE inspection suppression.
src/TouchPoint-WP/Utilities/DateTimeExtended.php	Adds i18n-friendly formatting helper.
src/TouchPoint-WP/Utilities/DateFormats.php	Fixes signature typo (trailing comma).
src/TouchPoint-WP/Utilities/Cleanup.php	Adjusts cache TTL semantics to seconds.
src/TouchPoint-WP/Utilities.php	Misc fixes: time parsing, GUID seeding, slug constant.
src/TouchPoint-WP/TouchPointWP.php	Core: version bump, blocks, lookup, caching tweaks, plugin meta.
src/TouchPoint-WP/TouchPointWP_Exception.php	Adds dev detail plumbing + trace escaping (but currently broken).
src/TouchPoint-WP/TouchPointWP_AdminAPI.php	Expands admin endpoints; adds devDetail console logging.
src/TouchPoint-WP/Taxonomies.php	Uses imported divisions helper; restricts taxonomy term editing.
src/TouchPoint-WP/StatusWidget.php	Improves dashboard widget output/i18n.
src/TouchPoint-WP/Stats.php	Adds involvement counts; modifies telemetry submission flow.
src/TouchPoint-WP/Settings.php	Refactors settings init to defer translations until ready.
src/TouchPoint-WP/Report.php	Fixes global `$post` handling during shortcode indexing.
src/TouchPoint-WP/PostTypeCapable.php	Introduces actionButtons interface; notableAttributes now returns NotableAttributes.
src/TouchPoint-WP/Person.php	Adds people list filters + AJAX endpoint + gender meta + action buttons changes.
src/TouchPoint-WP/Partner.php	REST visibility change + notable attributes/action buttons updates.
src/TouchPoint-WP/MeetingArray.php	Clarifies involvement backing type; imports stdClass.
src/TouchPoint-WP/Meeting.php	Consolidates interfaces; notableAttributes changes; RSVP button element change.
src/TouchPoint-WP/Lookup.php	New lookup API + transient caching.
src/TouchPoint-WP/Location.php	Fixes nullable parameter typing.
src/TouchPoint-WP/Interfaces/updatesViaCron.php	Adds explicit void return types.
src/TouchPoint-WP/Interfaces/involvementMeetingCommon.php	New shared interface for meeting/involvement.
src/TouchPoint-WP/Interfaces/apiMeeting.php	Adds involvementId property annotation.
src/TouchPoint-WP/Interfaces/actionButtons.php	New action buttons interface.
src/TouchPoint-WP/EventsCalendar.php	iOS deeplink handling adjustments.
src/TouchPoint-WP/CalendarGrid.php	Fixes nullable month/year typing.
src/TouchPoint-WP/Blocks/BlocksController.php	New block registration + CSS endpoint (manifest-based).
src/TouchPoint-WP/Auth.php	Adds styling/icon + changes admin redirect checks + endpoint path fix.
src/TouchPoint-WP/Api.php	Adds basic-auth GET; changes PAT GET signature; error-handling updates.
src/templates/parts/person-list.php	Uses injected list class + fallback empty content.
src/templates/parts/person-list-item.php	Computes actions once; adds CSS state class.
src/templates/parts/partner-list-item.php	Uses NotableAttributes stringification.
src/templates/parts/meeting-list-item.php	Uses NotableAttributes + adds child queries (involvements/meetings).
src/templates/parts/involvement-nearby-list.php	Uses wp.i18n.sprintf in KO binding.
src/templates/parts/involvement-list-item.php	Uses NotableAttributes stringification.
src/templates/partner-single.php	Adds enqueuePartialsStyle context.
src/templates/partner-archive.php	Adds enqueuePartialsStyle context.
src/templates/meeting-archive.php	Adds enqueuePartialsStyle context.
src/templates/involvement-single.php	Adds past/cancel alert + NotableAttributes join + style context.
src/templates/involvement-archive.php	Adds enqueuePartialsStyle context.
src/templates/admin/invKoForm.php	Uses short-cache meta fetch; tweaks copy; fixes default grouping value type.
src/python/WebApi.py	Backend changes: meeting status, meeting series, memtype filters, version bump.
src/js-partials/partner-map-inline.js	Switches to tpvm-scoped class access.
src/js-partials/involvement-nearby-inline.js	Switches to tpvm-scoped class access.
src/js-partials/involvement-map-inline.js	Switches to tpvm-scoped class access.
README.md	Removes FontAwesome mention; formatting tweak.
package.json	Version bump + adds WP block build deps/scripts.
composer.json	Version bump.
buildPipeline/versionUpdate.js	New script to sync versions across files.
build.sh	Updates build flow; adds block build + timing output.
blocks/people-list/index.js	New Gutenberg People List block with live preview.
blocks/people-list/block.json	Block metadata for People List.
blocks/inv-list/index.js	New Gutenberg Involvement List block with live preview.
blocks/inv-list/block.json	Block metadata for Involvement List.
blocks/common.js	Shared unique ID generator for blocks.
assets/template/partials-template-style.css	Person-list layout tweaks + marker animation + hover logic.
assets/template/calendar-grid-style.css	Grid styling improvements + responsive tweaks.
assets/template/block-preview-style.css	New editor preview overlay styling.
assets/template/actions-style.css	Adds mask-based icon system for actions.
assets/js/partner-defer.js	Refactors to tpvm namespace + marker/icon changes.
assets/js/meeting-defer.js	Refactors to tpvm namespace + wp.i18n helpers.
assets/icons/touchpoint.svg	New icon asset.
assets/icons/map-marker.svg	New icon asset.
assets/icons/lock.svg	New icon asset.
assets/branding/icon-curcolor.svg	Removes old inline SVG asset.
.idea/watcherTasks.xml	IDE watcher addition (project config).
.idea/phpunit.xml	IDE PHPUnit config (project config).
.idea/php.xml	IDE PHP include paths (project config).
.idea/misc.xml	IDE SDK metadata update (project config).
.idea/libraries/Generated_files.xml	IDE generated files list update (project config).
.gitignore	Ignores additional IDE/copilot files; removes package-lock ignore.

Files not reviewed (5)

.idea/libraries/Generated_files.xml: Language not supported
.idea/misc.xml: Language not supported
.idea/php.xml: Language not supported
.idea/phpunit.xml: Language not supported
.idea/watcherTasks.xml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-09T02:39:39Z

src/TouchPoint-WP/TouchPointWP_Exception.php

 				$message .= "<br />" . $this->getFile() . " @ " . $this->getLine() . "<br />";
-				$message .= str_replace("\n", "<br />", $this->getTraceAsString());
+				$message .= str_replace("\n", "<br />", esc_html($this->getTraceAsString()));
 			}
 			self::showAdminError($message);
 		}


$devDetail is accepted by the constructor but never forwarded to the admin notice. As a result, any developer detail intended for TouchPointWP_AdminAPI::showError() is dropped and showAdminError() later references an undefined $devDetail variable. Pass $devDetail into showAdminError() and add a parameter to showAdminError() so it can forward it safely.

Copilot · 2026-04-09T02:39:41Z

src/TouchPoint-WP/TouchPointWP_Exception.php

 			if ( ! TOUCHPOINT_COMPOSER_ENABLED) {
 				require_once 'TouchPointWP_AdminAPI.php';
 			}

-			TouchPointWP_AdminAPI::showError($message);
+			TouchPointWP_AdminAPI::showError($message, $devDetail);
 		}


$devDetail is not defined in this scope, so this call will raise a PHP notice and always pass null. showAdminError() should accept $devDetail as an argument (default null) and the constructor should pass it through.

Copilot · 2026-04-09T02:39:42Z

src/TouchPoint-WP/Blocks/BlocksController.php

+		$manifest_data = require $blocksRoot . '/blocks-manifest.php';
+		foreach ($manifest_data as $block_type) {
+			register_block_type($block_type['name'], $block_type);
+		}


BlocksController::init() unconditionally requires blocks-manifest.php, but the repo currently has no blocks/blocks-manifest.php (only block source folders). This will fatal when the plugin is run from source (non-built) or if the manifest is missing. Add a file_exists guard with a fallback to registering blocks from block.json files, or ensure the manifest is committed/generated in-place.

Copilot · 2026-04-09T02:39:42Z

src/TouchPoint-WP/Partner.php

 				'public'            => true,
 				'hierarchical'      => false,
 				'show_ui'           => false,
 				'show_in_nav_menus' => true,
-				'show_in_rest'      => false, // For the benefit of secure partners
+				'show_in_rest'      => true, // For the benefit of secure partners


This post type is public and is explicitly used for "secure partners"; switching show_in_rest to true makes partner content accessible via the REST API to anonymous users (unless additional REST restrictions exist). If secure partner data must not be exposed, keep show_in_rest disabled or add a REST permission_callback/rest_controller that enforces access rules.

Copilot · 2026-04-09T02:39:43Z

src/TouchPoint-WP/Lookup.php

+	public static function api(array $uri): bool
+	{
+		try {
+			header('Content-Type: application/json');
+			header('Cache-Control: public, max-age=60'); // 1 minute, to allow duplicates to be cached easily.
+			echo json_encode(self::getLookup($uri['path'][2]));
+			exit;


Lookup::api() reads $uri['path'][2] without validating the path length. Requests to /touchpoint-api/lookup (no trailing segment) will trigger an undefined offset notice. Add a count($uri['path']) < 3 guard similar to BlocksController::api().

Copilot · 2026-04-09T02:39:44Z

blocks/people-list/index.js

+        additionalClasses = additionalClasses.replace('is-selected', '').replace(/\s+/g, ' ').trim();
+
+        const genderClause = gender === 0 ? "" : ` gender="${gender}"`
+        const memTypesClause = memTypes !== [0] && memTypes.length > 0 ? ` memTypes="${memTypes.join(',')}"` : "";


This comparison is always true because arrays are compared by reference in JS (memTypes !== [0]). As written, the saved shortcode will always include a memTypes attribute whenever memTypes.length > 0, even when the default is [0]. Compare by value (e.g., memTypes.length === 1 && memTypes[0] === 0).

Suggested change

const memTypesClause = memTypes !== [0] && memTypes.length > 0 ? ` memTypes="${memTypes.join(',')}"` : "";

const memTypesClause = memTypes.length > 0 && !(memTypes.length === 1 && memTypes[0] === 0) ? ` memTypes="${memTypes.join(',')}"` : "";

Copilot · 2026-04-09T02:39:45Z

blocks/inv-list/index.js

+		const { attributes, setAttributes } = props;
+		const { postType, division } = attributes;
+		const blockProps = wp.blockEditor.useBlockProps();
+		const placeholderId = `tp-inv-list-${generateUniqueId()}`;


placeholderId changes on every render because generateUniqueId() is called during render. That can break refs/effects and cause extra fetches or stale DOM updates. Use useRef(generateUniqueId()) (like the People List block) so the ID is stable for the block instance.

Suggested change

const placeholderId = `tp-inv-list-${generateUniqueId()}`;

const placeholderIdRef = wp.element.useRef(`tp-inv-list-${generateUniqueId()}`);

const placeholderId = placeholderIdRef.current;

Copilot · 2026-04-09T02:39:45Z

src/templates/parts/person-list.php

+if (count($people) > 0) { ?>

-<div <?php post_class("person-list"); ?>>
+<div class="<?php echo $listClass; ?>" >
 <?php


$listClass is output into an HTML attribute without escaping/sanitization. Since it comes from shortcode/GET parameters, this is an XSS vector. Use esc_attr() and ideally sanitize the classes (e.g., split and run through sanitize_html_class).

Copilot · 2026-04-09T02:39:45Z

src/templates/parts/meeting-list-item.php

+			                         'meta_query' => [
+				                         [
+					                         'key' => Meeting::MEETING_META_KEY,
+					                         'value' => 0,
+					                         'compare' => '!='
+				                         ],
+			                         ]


This meta query uses compare != 0, which in WP meta queries can also match posts where the meta key is missing, potentially pulling unrelated children and doing extra work. If the intent is “only children with this meta key set”, use compare => 'EXISTS' (and then filter by value) or a stricter numeric comparison.

Copilot · 2026-04-09T02:39:45Z

src/templates/parts/meeting-list-item.php

+
+			if (!Meeting::postIsType($child)) {
+				// This is just a precaution; it shouldn't happen because the query above only includes involvements.
+				continue;
+			}


The comment says the query “only includes involvements”, but this block is querying by Meeting::MEETING_META_KEY and then instantiating Meeting objects. This looks like a copy/paste mismatch that makes the template harder to maintain (and the wrapper class name child-involvements is also reused for meeting children).

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jkrrv added 30 commits February 8, 2024 21:22

Improving links to docs and such in the plugin listing.

217da3d

Correct an issue with unset values

9c1be92

Better error reporting for API issues

f64a129

Correcting some @SInCE tags

Typo

cd04234

Resolve an issue of a deprecated cast

ffef10b

Shorten cache of divisions and other meta from TouchPoint in certain …

51a9e1c

…situations (closes #179). Also, improve error handling for script updates.

A variety of minor cleanup items, mostly related to #225.

b065c4c

Resolving login with tokens. Closes #211.

992a8ca

Resolving overly-aggressive redirection. Closes #228.

daeb404

Resolving overly-aggressive redirection. Closes #228. For real this t…

0d29b33

…ime.

Handle some variables more gracefully for unusual circumstances.

ea7be21

Resolving an issue where not all children of involvements are involve…

74a43e5

…ments.

i18n update

764b108

Starting to resolve issue of calling translations too early.

0befb4d

Resolve issue of calling translations too early. Closes #230

1a516b9

Fix implicit nullables

ad153de

Efficiency improvements

7ebc019

Resolve an issue where stats reporting was printing results (and bloc…

17a3cf4

…king) when it shouldn't have.

Patch: raise priority of Main Leader for contacting leaders.

5a46ad2

Patch: raise priority of Main Leader for contacting leaders.

68dd944

Fix implicit nullables

ef09210

Efficiency improvements

0e4be1f

Resolve an issue where stats reporting was printing results (and bloc…

e43bd08

…king) when it shouldn't have.

Merge branch 'CurrentTenth' into block2

1402361

Making global declaration of i18n functions safer.

f011cce

Finally correcting JS scoping

53763e1

Reworking usage of Google Maps library to account for API changes. Cl…

6118059

…oses #220.

Changing people lists to not have hover behavior if there are no acti…

c42f443

…ons. Closes #229

Missed a scoping issue.

77255fa

Making tp_person_actions filter more flexible.

6fd59c9

jkrrv added 19 commits April 1, 2026 10:17

docs update

64c87fa

Merge CurrentTenth to Next

62ee68d

Merge cleanup

4472d6e

cherry-pick:Starting process to allow involvement sync to be split in…

fe53b28

…to smaller chunks.

Fix actions style not being imported

c48b061

clarifying a label

c35e693

moving actions style call where it belongs

b339c8e

Resolve an issue with timezone formatting. Closes #243.

f784893

Resolve an issue where partner map sometimes isn't initializing corre…

a5f41b3

…ctly.

Finally resolving the issue with the calendar right-hand border

c9ebcdb

cleaning up capitalization of labels, i18n.

12cf81a

add flush-rewrite api endpoint

4cf1fb1

resolve icons not appearing in block editor

e415bb6

rollback of really bad decision to think meetings would be translatab…

22dc8a9

…le. They are not, at least not currently.

Adding some other fields to avoid translation

2f8a4e3

Managing translations better.

d45adc9

Styling improvements

638ea3e

remove useless trailing comma

e51469b

i18n update

0994122

Copilot AI review requested due to automatic review settings April 9, 2026 02:33

Copilot started reviewing on behalf of jkrrv April 9, 2026 02:34 View session

package updates

349b3bf

Copilot AI reviewed Apr 9, 2026

View reviewed changes

jkrrv and others added 7 commits April 8, 2026 22:51

Code review

96b4376

Update .github/workflows/releases.yml

5bd7eb1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Code review

fc99a63

Make it easier to tell when redirections are due to tpwp.

75f53d5

i18n

08d1219

FINALLY fixed partner taxonomy

a512f6a

i18n

557d7b6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore Next to being the useful primary development branch#226

Restore Next to being the useful primary development branch#226
jkrrv wants to merge 139 commits intoblocksfrom
next

jkrrv commented Apr 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const memTypesClause = memTypes !== [0] && memTypes.length > 0 ? ` memTypes="${memTypes.join(',')}"` : "";
	const memTypesClause = memTypes.length > 0 && !(memTypes.length === 1 && memTypes[0] === 0) ? ` memTypes="${memTypes.join(',')}"` : "";

	const placeholderId = `tp-inv-list-${generateUniqueId()}`;
	const placeholderIdRef = wp.element.useRef(`tp-inv-list-${generateUniqueId()}`);
	const placeholderId = placeholderIdRef.current;

Conversation

jkrrv commented Apr 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants