fix(Typography): ellipsis unexpectedly splits a word across two lines
#3997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RylanBot
requested review from
HaixingOoO,
NWYLZW,
ZWkang,
carolin913,
honkinglin and
uyarn
as code owners
commit: |
Contributor
|
|
HaixingOoO
requested review from
Copilot
and removed request for
HaixingOoO,
NWYLZW,
ZWkang,
carolin913,
honkinglin and
uyarn
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Typography component's ellipsis feature where English words were unexpectedly split across two lines when truncated. The fix introduces intelligent word boundary detection to break text at appropriate points (spaces, hyphens, punctuation) rather than mid-word.
Key Changes:
- Added
breakAtWordBoundary()method to detect and break at word boundaries - Applied word boundary logic to both last-line truncation and multi-line truncation scenarios
- Minor formatting improvements to existing CHANGELOG entries
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/components/typography/ellipsis/Truncate.tsx | Adds breakAtWordBoundary() method and integrates it into the text truncation algorithm to prevent words from being split across lines |
| packages/tdesign-react/CHANGELOG.md | Formatting improvements to existing entries (spacing around backticks), but missing a new entry for this PR |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
https://tdesign.tencent.com/react/components/typography#可省略
📝 更新日志
fix(Typography): 修复开启
ellipsis时，将一个完整英文单词切割放在两行的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单