Skip to content

feat(web): preserve mobile view state using React Activity boundary #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xyspg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(web): preserve mobile view state using React Activity boundary #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions apps/web/src/app/dashboard/register/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { api } from "@albert-plus/server/convex/_generated/api";
import { useConvexAuth, usePaginatedQuery, useQuery } from "convex/react";
import { CalendarIcon, ListIcon } from "lucide-react";
import { useEffect, useRef, useState } from "react";
import { Activity, useEffect, useRef, useState } from "react";
import { useNextTerm, useNextYear } from "@/components/AppConfigProvider";
import { Label } from "@/components/ui/label";
import { Switch } from "@/components/ui/switch";
Expand Down Expand Up @@ -172,7 +172,7 @@ const RegisterPage = () => {

{/* Mobile view */}
<div className="md:hidden flex-1 min-h-0">
{mobileView === "selector" ? (
<Activity mode={mobileView === "selector" ? "visible" : "hidden"}>
<CourseSelector
courseOfferingsWithCourses={displayedResults}
onHover={setHoveredCourse}
Expand All @@ -185,9 +185,10 @@ const RegisterPage = () => {
onCourseSelect={handleCourseSelect}
selectedClassNumbers={selectedClassNumbers}
/>
) : (
</Activity>
<Activity mode={mobileView === "calendar" ? "visible" : "hidden"}>
<div className="h-full flex flex-col space-y-2">
<div className="md:hidden relative flex w-full items-start gap-2 rounded-md border border-input p-4 shadow-xs outline-none has-data-[state=checked]:border-primary/50">
<div className="relative flex w-full items-start gap-2 rounded-md border border-input p-4 shadow-xs outline-none has-data-[state=checked]:border-primary/50">
<AltToggle />
</div>
<ScheduleCalendar
Expand All @@ -197,7 +198,7 @@ const RegisterPage = () => {
onCourseSelect={handleCourseSelect}
/>
</div>
)}
</Activity>
</div>

{/* Desktop view */}
Expand Down