Upgrade gems and yarn dependencies for housekeeping #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reefdog
suggested changes
Apr 28, 2020
Contributor
reefdog
left a comment
reefdog
left a comment
There was a problem hiding this comment.
- Requesting change/clarification: When I run
yarn install, the lockfile changes in a few ways. Can you verify that runningyarn installon your end generates no lockfile differences? - FYI only: When I run
rail test, I get 1 failure and 5 errors. (I get the same on master so this isn't new.)
Basic security upgrade resolves #57
Contributor
Author
|
I decided to use this PR to also upgrade Rails #57 really quickly. |
reefdog
suggested changes
May 19, 2020
Contributor
reefdog
left a comment
reefdog
left a comment
There was a problem hiding this comment.
There may be an incompatibility between Rails 6.0.3 and one of our gems, perhaps Administrate, because when I log in and click the "Admin" nav link (which goes to /admin/categories), it throws a NoMethodError:
I verified this didn't happen on the master branch, so this is new to this branch/PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates a number of things for basic housekeeping and to fix some security issues.