Skip to content

Conversation

@StevenClontz
Copy link
Contributor

@StevenClontz StevenClontz commented Jul 23, 2025

Closes #848

@StevenClontz StevenClontz changed the title special preview targets Final housekeeping for 2025 editions Jul 23, 2025
@github-actions
Copy link

🚀 Preview available 🚀

https://ad0d4125.tbil.pages.dev

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@StevenClontz StevenClontz mentioned this pull request Jul 25, 2025
@github-actions
Copy link

@github-actions
Copy link

StevenClontz and others added 2 commits July 31, 2025 03:32
Co-authored-by: cg2wilson <cory.g.wilson@gmail.com>
@github-actions
Copy link

@StevenClontz StevenClontz marked this pull request as ready for review July 31, 2025 03:56
@StevenClontz StevenClontz requested a review from siwelwerd July 31, 2025 03:56
@siwelwerd
Copy link
Contributor

Looks like the PDF versions of both Precalculus and Calculus are only partially building. I'll see if I can get that figured out today.

@StevenClontz
Copy link
Contributor Author

StevenClontz commented Jul 31, 2025 via email

@siwelwerd
Copy link
Contributor

May just be a caching thing... I assumed since they showed up at the new 2025 URL they had been built but maybe not? Precalc built fine in the devcontainer, testing out Calculus now

Copy link
Contributor

@siwelwerd siwelwerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, they both built fine. Going ahead and approving, you can merge as soon as you confirm that there is no reason the PDF in the preview should be working.

@StevenClontz
Copy link
Contributor Author

Now I remember - there's some kind of asset that's not building by default, and its absence breaks the PDF builds. Booting up a codespace now...

@siwelwerd
Copy link
Contributor

I did have to run Calculus with the -g flag to get it to do the QR codes

@github-actions
Copy link

@siwelwerd
Copy link
Contributor

I think we're good?

Nope, Calculus is still crapping out after 18 pages (I think when it gets to the first QR code). Precalc student PDF looks good, but instructor PDF doesn't.

@StevenClontz
Copy link
Contributor Author

StevenClontz commented Jul 31, 2025 via email

@siwelwerd
Copy link
Contributor

I think the caching error has resolved, but the precalc instructor still wasn't working. It wouldn't compile locally, but now it does. I guess there was an error in math mode, that MathJax would report as an error, but PreTeXt doesn't check that things in <m> tags are valid. Thus building HTML reported success, but LaTeX failed.

Latest commit should fix this.

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

@siwelwerd
Copy link
Contributor

@StevenClontz Can you verify the precalc instructor PDF is good now, and then we can merge this.

@StevenClontz
Copy link
Contributor Author

Building and deploying it now. If it looks good, I'll merge this so the website launches with the 2025 edition links.

@StevenClontz StevenClontz merged commit 0edd761 into main Aug 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated commentary element

3 participants