Fix search not working in drawer category views#4586
Open
geoffreysisco wants to merge 1 commit intoTeamAmaze:release/4.0from
Open
Fix search not working in drawer category views#4586geoffreysisco wants to merge 1 commit intoTeamAmaze:release/4.0from
geoffreysisco wants to merge 1 commit intoTeamAmaze:release/4.0from
Conversation
Drawer categories (Quick Access, Recent Files, Images, Videos,
Audio, Documents, APKs, Trash Bin) use numeric paths ("0"–"7")
instead of real filesystem directories.
BasicSearch expects a filesystem path, so searches silently returned
no results when run from these views.
When the current view uses OpenMode.CUSTOM or OpenMode.TRASH_BIN,
search now runs against the visible dataset
(MainFragmentViewModel.listElements) instead of the filesystem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drawer categories (Quick Access, Recent Files, Images, Videos, Audio,
Documents, APKs, Trash Bin) use numeric paths ("0"–"7") instead of real
filesystem directories.
BasicSearch expects a filesystem path, so searches silently returned no
results when run from these views.
When the current view uses
OpenMode.CUSTOMorOpenMode.TRASH_BIN,search now runs against the visible dataset
(
MainFragmentViewModel.listElements) instead of the filesystem.Issue tracker
Fixes #4561
Automatic tests
Manual tests
Device: Pixel 9 Pro (emulator)
OS: Android 16 (API 36)
Rooted: No
Build: debug
Verified search in:
Could not verify:
Build tasks success
Successfully running following tasks locally:
./gradlew assembleDebug./gradlew spotlessCheck