Skip to content

Proguard rules fix to include everything below org.bouncycastle.jcajce.provider.asymmetric#4537

Merged
EmmanuelMess merged 1 commit into
hotfix/3.11.2from
bugfix/sshj-release-proguard-fix
May 17, 2026
Merged

Proguard rules fix to include everything below org.bouncycastle.jcajce.provider.asymmetric#4537
EmmanuelMess merged 1 commit into
hotfix/3.11.2from
bugfix/sshj-release-proguard-fix

Conversation

@TranceLove
Copy link
Copy Markdown
Collaborator

@TranceLove TranceLove commented Jan 1, 2026

Description

Update Proguard rules to fix SSH connection problems in recent release builds.

Source was from this ClassNotFoundException when attempting to create new connection, using ed25519 SSH key in 3.11.2 release builds.

Caused by: java.lang.ClassNotFoundException: Didn't find class "org.bouncycastle.jcajce.provider.asymmetric.edec.KeyPairGeneratorSpi$X25519" on path: DexPathList[[dex file "/data/data/com.amaze.filemanager/code_cache/.overlay/base.apk/classes.dex", dex file "/data/data/com.amaze.filemanager/code_cache/.overlay/base.apk/classes2.dex", zip file "/data/app/~~v1Lwt-x3qdOVJvGNkmr4Uw==/com.amaze.filemanager-vFjCNGE_AUHlBJMfD-Pkkw==/base.apk"],nativeLibraryDirectories=[/data/app/~~v1Lwt-x3qdOVJvGNkmr4Uw==/com.amaze.filemanager-vFjCNGE_AUHlBJMfD-Pkkw==/lib/arm64, /data/app/~~v1Lwt-x3qdOVJvGNkmr4Uw==/com.amaze.filemanager-vFjCNGE_AUHlBJMfD-Pkkw==/base.apk!/lib/arm64-v8a, /system/lib64, /system_ext/lib64]]
at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
at java.lang.ClassLoader.loadClass(ClassLoader.java:637)
at java.lang.ClassLoader.loadClass(ClassLoader.java:573)
at java.security.Provider$Service.getImplClass(Provider.java:1725)
... 20 more

Probably some changes to the BouncyCastle library we didn't notice, while we removed system's built-in BC provider, causing the problem.

Issue tracker

Automatic tests

  • Added test cases

Manual tests

  • Done

  • Device: Fairphone 5

  • OS: LineageOS 23.0 (Android 16)
    SftpConnectDialog should successfully save a new SSH connection, and hence be able to connect to the SSH server.

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

…e.provider.asymmetric

Fixes problems with SSH connections in recent release builds
@EmmanuelMess EmmanuelMess merged commit ae50772 into hotfix/3.11.2 May 17, 2026
5 checks passed
@EmmanuelMess EmmanuelMess deleted the bugfix/sshj-release-proguard-fix branch May 17, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-No-Code-Changes These PRs do not change any code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants