Skip to content

[refactor] 공지사항 API RESTful 설계 복구 및 이슈 범위 외 코드 제거 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geunyong16 merged 5 commits into from
May 3, 2026
Merged

[refactor] 공지사항 API RESTful 설계 복구 및 이슈 범위 외 코드 제거 #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e36adef
feat(workplace): add isActive filter to workplace list API
geunyong16 Apr 30, 2026
f945dc9
fix(workplace): align test with isActive=null behavior
geunyong16 May 3, 2026
dfa8989
fix(notice): add workplace selection to notice creation and fix test …
geunyong16 May 3, 2026
e6ae5d3
fix(test): update NoticeServiceTest to match new createNotice signature
geunyong16 May 3, 2026
9d98973
refactor(notice): revert notice API to RESTful path variable and remo…
geunyong16 May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/example/paycheck/domain/notice/service/NoticeService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public NoticeDto.Response createNotice(Long workplaceId, User author, NoticeDto.
publishNoticeCreatedNotification(saved);
} catch (Exception e) {
log.error("공지사항 생성은 성공했지만 알림 발행에 실패했습니다. noticeId={}, workplaceId={}",
saved.getId(), workplaceId, e);
saved.getId(), workplace.getId(), e);
}
return NoticeDto.Response.from(saved);
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/example/paycheck/domain/workplace/service/WorkplaceServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ void getWorkplaceById_NotFound() {
}

@Test
@DisplayName("사용자 ID로 사업장 목록 조회 성공")
@DisplayName("사용자 ID로 사업장 목록 조회 성공 - 활성 사업장만 조회")
void getWorkplacesByUserId_Success() {
// given
when(employerService.getEmployerByUserId(1L)).thenReturn(testEmployer);
Expand Down
Loading