-
Notifications
You must be signed in to change notification settings - Fork 0
Stage to Prod #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage to Prod #59
Conversation
- [1564](https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/1564/) - Added a package object in response which contains custom package name and version - [1566](https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/1566/) - Updated readme for env variable details
Fixed task 1564 and 1566
- Fixed [1654](https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/1654) - Added functionality to retain the ext tags - Fixed [2040](https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/2040) - Removing the width tag if the width is not float or integer
Fixed task 1654 and 2040
Feature resolve conflicts
Dev to Stage
…s-08-08 Resolve conflicts
[Resolve Conflicts]Dev to Stage
| if upload_url: | ||
| upload_message.data.formatted_url = upload_url | ||
|
|
||
| resp_data = upload_message.data.to_json() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is changing the response message format from this service back. How to ensure the integrity of the message? there is no unit test to check the sanity of the response message
susrisha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested
Uh oh!
There was an error while loading. Please reload this page.