Skip to content

Conversation

@sujata-m
Copy link
Collaborator

@sujata-m sujata-m commented Aug 7, 2025

  • Fixed 1654
  • Added functionality to retain the ext tags
  • Fixed 2040
  • Removing the width tag if the width is not float or integer

sujata-m and others added 7 commits December 23, 2024 14:02
- [1564](https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/1564/)
    - Added a package object in response which contains custom package name and version
- [1566](https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/1566/)
    - Updated readme for env variable details
- Fixed [1654](https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/1654)
- Added functionality to retain the ext tags
- Fixed [2040](https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/2040)
- Removing the width tag if the width is not float or integer
@sujata-m sujata-m requested review from MashB and susrisha August 7, 2025 17:59
if upload_url:
upload_message.data.formatted_url = upload_url

resp_data = upload_message.data.to_json()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is changing the response message format from this service back. How to ensure the integrity of the message? there is no unit test to check the sanity of the response message

Copy link
Collaborator

@susrisha susrisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested

@sujata-m sujata-m merged commit 0bcb5fc into main Aug 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants