Refactor/tas 35#21
Merged
maksberegovoi merged 2 commits intodevfrom Apr 1, 2026
Merged
Conversation
maksberegovoi
requested review from
kapitulin24 and
perekljuchatel
as code owners
perekljuchatel
requested changes
Mar 31, 2026
Member
perekljuchatel
left a comment
perekljuchatel
left a comment
There was a problem hiding this comment.
Никуда не годится. Это просто каша-малаша. Причины конечно понятны, ты их указал, и я постараюсь найти в выходные время забрать ветку, посмотреть, что получилось и будем ли двигать бек от этого дальше. Но на будущее - давай придерживаться стандарта Conventional Commits (писать, что конкретно изменилось, и можно, а как по мне даже лучше - по русски подробнее). Так же делать squash, объединяя комиты в которых есть логическое действие. Спешка совсем не нужна, я нигде не видел что это тут на скорость задачки.
- Fix: resolve user creation with ADMIN role and response typing (ref TAS-40) - Feature: implement RolesGuard and custom decorators (CurrentUser, Roles) (ref TAS-51) - Feature: add logout method and password update functionality - Refactor: rename /user to /users (ref TAS-41) - Migrate: personal routes to /me - Optimization: remove local strategy and DB request in JWT strategy (ref TAS-47) - Chore: update ESLint config to ignore "_" for unused variables Detailed changes: - Moved 'me' method logic to user service for better separation of concerns - Added specialized response types and selectors for Private and Public user data - Cleaned up auth strategies to improve performance
maksberegovoi
force-pushed
the
refactor/TAS-35
branch
from
022228a to
dc2cfd0
Compare
kapitulin24
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.