refactor: login, register pages#18
Closed
Pikaz0r922 wants to merge 1 commit intodevfrom
Closed
Conversation
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
reviewed
Mar 25, 2026
kapitulin24
requested changes
Mar 26, 2026
Pikaz0r922
force-pushed
the
refactor-TAS-26
branch
3 times, most recently
from
c720d0f to
35f4abf
Compare
Pikaz0r922
force-pushed
the
refactor-TAS-26
branch
from
35f4abf to
6052326
Compare
kapitulin24
reviewed
Apr 1, 2026
| return ( | ||
| <> | ||
| <div className="bg-gray-100 rounded-lg h-64 flex items-center justify-center text-gray-400 mt-8"> | ||
| Скриншот интерфейса |
Contributor
There was a problem hiding this comment.
скриншота тут быть не должно, не обратил внимания что написал комент на весь блок. Соответственно компонент нужно переименовать по смыслу
kapitulin24
reviewed
Apr 1, 2026
| @@ -0,0 +1,12 @@ | |||
| 'use client'; | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Типизация. Пропсы и возвращаемое значение
kapitulin24
reviewed
Apr 1, 2026
| @@ -0,0 +1,12 @@ | |||
| 'use client'; | |||
Contributor
There was a problem hiding this comment.
Компонент может работать как серверный
kapitulin24
reviewed
Apr 1, 2026
| <div className="bg-gray-100 rounded-lg h-64 flex items-center justify-center text-gray-400 mt-8"> | ||
| Скриншот интерфейса | ||
| </div> | ||
| <p className="text-gray-500 text-sm mt-4">© {new Date().getFullYear()} TaskTracker Lab.</p> |
Contributor
There was a problem hiding this comment.
text-muted-foreground. mt-4 не нужен
kapitulin24
reviewed
Apr 1, 2026
|
|
||
| import { Button, InputGroup, InputGroupAddon, InputGroupInput } from 'shared/ui'; | ||
| import { useState } from 'react'; | ||
| export function PasswordInput(props: React.InputHTMLAttributes<HTMLInputElement>) { |
Contributor
There was a problem hiding this comment.
- нужен более "тупой" компонент. Это будет компонент который меняет иконку по пропсу, всё остальное верни где было.
- Пустая строка между компонентом и импортами
- Переименуй по компонент по смыслу
kapitulin24
reviewed
Apr 1, 2026
| @@ -0,0 +1,20 @@ | |||
| 'use client'; | |||
kapitulin24
reviewed
Apr 1, 2026
|
|
||
| export function AppLogo() { | ||
| return ( | ||
| <div className="flex items-center mb-20 gap-3"> |
Contributor
There was a problem hiding this comment.
никаких mb. почитай про схлопывание марджинов
kapitulin24
reviewed
Apr 1, 2026
| import Image from 'next/image'; | ||
| import { LogoImage } from 'shared/assets'; | ||
|
|
||
| export function AppLogo() { |
Contributor
There was a problem hiding this comment.
типизация. пропсы и возвращаемое значение
Contributor
There was a problem hiding this comment.
нужно добавить возможность выбора варианта логотипа и размера. Точно так же как это сделано в shared/ui/button
kapitulin24
reviewed
Apr 1, 2026
| return ( | ||
| <div className="flex items-center mb-20 gap-3"> | ||
| <Image src={LogoImage} alt="logo" /> | ||
| <h1 className="text-2xl font-bold">TaskTracker Lab</h1> |
kapitulin24
reviewed
Apr 1, 2026
| <div className="hidden md:flex flex-col justify-between bg-secondary p-10 w-1/2"> | ||
| <div> | ||
| <AppLogo /> | ||
| <div className="mb-4"> |
Contributor
There was a problem hiding this comment.
лучше вместо mb-4 задать mt-4 ScreenshotPlaceholder
kapitulin24
reviewed
Apr 1, 2026
| </div> | ||
| <RegisterForm /> | ||
| <div className="flex gap-3 justify-center text-sm"> | ||
| <p className="text-muted-foreground mb-6">уже есть аккаунт?</p> |
Contributor
There was a problem hiding this comment.
вместо mb-6 для блока div pb-6
kapitulin24
reviewed
Apr 1, 2026
| } | ||
|
|
||
| @theme { | ||
| --color-link: oklch(54.6% 0.245 262.881); |
Contributor
There was a problem hiding this comment.
странная строчка. нужно --color-link: var(--link); и выше в @theme inline
kapitulin24
reviewed
Apr 1, 2026
| body { | ||
| @apply bg-background text-foreground; | ||
| } | ||
| button:not(:disabled), |
Contributor
There was a problem hiding this comment.
это в shared/ui/button нужно
kapitulin24
reviewed
Apr 1, 2026
| return ( | ||
| <form className="space-y-6 mb-4" onSubmit={handleSubmit(onSubmit)}> | ||
| <div className="flex flex-col space-y-4"> | ||
| <form className="space-y-6 mb-6" onSubmit={handleSubmit(onSubmit)}> |
Contributor
There was a problem hiding this comment.
mb-6 не нужен, этот отступ лучше задать другим способом в пэйдже
kapitulin24
reviewed
Apr 1, 2026
| {errors.email && ( | ||
| <FieldDescription className="text-red-500">{errors.email.message}</FieldDescription> | ||
| )} | ||
| {errors.email && <FieldError className="text-red-500">{errors.email.message}</FieldError>} |
Contributor
There was a problem hiding this comment.
зачем тут кастомный text-red?
kapitulin24
reviewed
Apr 1, 2026
| <FieldDescription className="text-red-500 text-sm"> | ||
| {errors.password.message} | ||
| </FieldDescription> | ||
| <FieldError className="text-red-500 text-sm">{errors.password.message}</FieldError> |
Contributor
There was a problem hiding this comment.
зачем тут кастомный text-red? еще и размер текста
kapitulin24
reviewed
Apr 1, 2026
| <FieldError className="text-red-500 text-sm">{errors.password.message}</FieldError> | ||
| )} | ||
| </Field> | ||
| <div className="flex items-center justify-between text-sm"> |
Contributor
There was a problem hiding this comment.
label все равно переопределяет размер текста. если он нужен, то тогда нужно его только для link задать
kapitulin24
reviewed
Apr 1, 2026
| </Link> | ||
| </Label> | ||
| {errors.terms && ( | ||
| <FieldError className="text-red-500 text-xs ml-6">{errors.terms.message}</FieldError> |
kapitulin24
reviewed
Apr 1, 2026
| )} | ||
| /> | ||
| Я согласен с | ||
| <Link href="/auth/reset-password" className="text-link hover:underline"> |
Contributor
There was a problem hiding this comment.
нужно создать Link в shared/ui с нужными стилями
kapitulin24
reviewed
Apr 1, 2026
| </Field> | ||
| <div className="flex items-center justify-between text-sm"> | ||
| <Label className="flex items-center gap-2"> | ||
| <Checkbox /> |
Contributor
There was a problem hiding this comment.
нужен в схеме и контролируемый ввод
kapitulin24
reviewed
Apr 1, 2026
| <Checkbox /> | ||
| Запомнить меня | ||
| </Label> | ||
| <Link href="/auth/reset-password" className="text-link hover:underline"> |
Contributor
There was a problem hiding this comment.
про линк где-то в регистрации писал уже
kapitulin24
reviewed
Apr 1, 2026
| @@ -1,19 +1,34 @@ | |||
| 'use client'; | |||
Contributor
There was a problem hiding this comment.
должен работать как серверный, вроде ничего не мешает
kapitulin24
requested changes
Apr 1, 2026
Contributor
kapitulin24
left a comment
kapitulin24
left a comment
There was a problem hiding this comment.
в папке shared/ui пишем в кебаб-кейс как уже заведено в shadcn дабы каждый компонент не переименовывать при добавлении. Все остальное в кэмел кейс.
ошибки в регистрации аналогичны логину и наоборот, так что всё не писал
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.