Skip to content

fix: Orchestrator - Only setting execution node status to CANCELLED after the container execution is terminated #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ark-kun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Orchestrator - Only setting execution node status to CANCELLED after the container execution is terminated #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions cloud_pipelines_backend/orchestrator_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,13 +707,19 @@ def internal_process_one_running_execution(
container_execution.status = bts.ContainerExecutionStatus.CANCELLED
terminated = True

# Marking the execution nodes as cancelled only after the launched container is successfully terminated
for execution_node in votes_to_terminate:
_logger.info(
f"Marking the execution node {execution_node.id} as CANCELLED."
)
execution_node.container_execution_status = (
bts.ContainerExecutionStatus.CANCELLED
)

# Mark the execution nodes as cancelled only after the launched container is successfully terminated (if needed)
for execution_node in votes_to_terminate:
_logger.info(
f"Cancelling execution {execution_node.id} and skipping all downstream executions."
)
execution_node.container_execution_status = (
bts.ContainerExecutionStatus.CANCELLED
f"Skipping all downstream executions of cancelled execution node {execution_node.id}."
)
_mark_all_downstream_executions_as_skipped(
session=session, execution=execution_node
Expand Down
Loading