Rework TaskInput and TaskOutput logic #1039
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2025
Draft
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 2, 2025
camielvs
force-pushed
the
10-01-rework_taskinput_and_taskoutput_logic
branch
from
d907fc5 to
8c6b0e0
Compare
camielvs
force-pushed
the
09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids
branch
from
972ef4a to
d32734d
Compare
camielvs
force-pushed
the
10-01-rework_taskinput_and_taskoutput_logic
branch
from
8c6b0e0 to
c073c29
Compare
camielvs
force-pushed
the
09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids
branch
from
d32734d to
cc0477e
Compare
camielvs
force-pushed
the
10-01-rework_taskinput_and_taskoutput_logic
branch
from
c073c29 to
2c0c04d
Compare
camielvs
force-pushed
the
09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids
branch
from
cc0477e to
7a923f3
Compare
camielvs
force-pushed
the
10-01-rework_taskinput_and_taskoutput_logic
branch
from
2c0c04d to
0cce84d
Compare
camielvs
force-pushed
the
09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids
branch
from
7a923f3 to
b33644c
Compare
camielvs
force-pushed
the
10-01-rework_taskinput_and_taskoutput_logic
branch
from
0cce84d to
6c541af
Compare
camielvs
changed the base branch from
09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids
to
graphite-base/1039
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Folded into #1017
Moves TaskInput node type and TaskOutput node type to be stored inside the node manager as a subset of their respective task node. This also reworks input and output nodes to no longer rely on TaskInput and TaskOutput types; instead it is assumed that the node handles are unique and distinct to the node itself.
This PR is a continuation of the previous and may be merged down into it to simplify.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments