feat: add e2e and perf tests for useExperimentalDOMVirtualizer with hook injection#1141
Draft
piecyk wants to merge 2 commits intoTanStack:mainfrom
Draft
feat: add e2e and perf tests for useExperimentalDOMVirtualizer with hook injection#1141piecyk wants to merge 2 commits intoTanStack:mainfrom
piecyk wants to merge 2 commits intoTanStack:mainfrom
Conversation
|
|
View your CI Pipeline Execution ↗ for commit 1cd67a0
☁️ Nx Cloud last updated this comment at |
2 tasks
5748d9c to
9d1b31c
Compare
95b74d4 to
525ee89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Performance Comparison:
useVirtualizervsuseExperimentalDOMVirtualizerAll 32 tests passed (34.7s).
useVirtualizeruseExperimentalVirtualizerKey Takeaways
How it works
useExperimentalVirtualizerbypasses React re-renders for item positioning by directly mutating DOM styles (transform,height) during scroll. It only triggers a React re-render when the visible range orisScrollingstate changes, which happens far less frequently than per-frame position updates.Test setup
contain: strict,overflowAnchor: none✅ Checklist
pnpm run test:pr.🚀 Release Impact