WIP: fix(solid-table): adapt to Solid v2 beta reactivity model#6242
WIP: fix(solid-table): adapt to Solid v2 beta reactivity model#6242brenelz wants to merge 1 commit intoTanStack:alphafrom
Conversation
brenelz
commented
May 5, 2026
brenelz
commented
- Wrap props in FlexRender with accessor functions and use createMemo inside Match callbacks so reactive reads happen in tracking scopes (resolves STRICT_READ_UNTRACKED warnings).
- Update basic-app-table example to call accessor args (row(), cell(), header(), footerGroup()) returned by Solid v2's callbacks.
- Wrap <Match when> props in FlexRender with accessor functions and use createMemo inside Match callbacks so reactive reads happen in tracking scopes (resolves STRICT_READ_UNTRACKED warnings). - Update basic-app-table example to call accessor args (row(), cell(), header(), footerGroup()) returned by Solid v2's <For> callbacks.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 7a51f3e
☁️ Nx Cloud last updated this comment at |
| "@tanstack/solid-store": "^0.11.0", | ||
| "goober": "^2.1.18", | ||
| "solid-js": "^1.9.12" | ||
| "solid-js": "^1.9.7" |
2 participants
