Skip to content

fix: ensure mutable atoms ignore internal no-arg updates#289

Merged
KevinVandy merged 2 commits intomainfrom
davidkpiano/fix-table-issue
Mar 7, 2026
Merged

fix: ensure mutable atoms ignore internal no-arg updates#289
KevinVandy merged 2 commits intomainfrom
davidkpiano/fix-table-issue

Conversation

@davidkpiano
Copy link
Collaborator

🎯 Changes

Fix a regression where mutable atoms could be updated internally with no updater and have their snapshot replaced with undefined.

Mutable atoms now ignore internal no-argument _update() calls, while computed atoms keep existing recomputation behavior. This prevents external-store state from disappearing during reactive graph cleanup.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@nx-cloud
Copy link

nx-cloud bot commented Mar 6, 2026

View your CI Pipeline Execution ↗ for commit 743d06d

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 43s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 17s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-06 21:05:44 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 6, 2026

@tanstack/angular-store

npm i https://pkg.pr.new/@tanstack/angular-store@289

@tanstack/preact-store

npm i https://pkg.pr.new/@tanstack/preact-store@289

@tanstack/react-store

npm i https://pkg.pr.new/@tanstack/react-store@289

@tanstack/solid-store

npm i https://pkg.pr.new/@tanstack/solid-store@289

@tanstack/store

npm i https://pkg.pr.new/@tanstack/store@289

@tanstack/svelte-store

npm i https://pkg.pr.new/@tanstack/svelte-store@289

@tanstack/vue-store

npm i https://pkg.pr.new/@tanstack/vue-store@289

commit: fe118fa

@KevinVandy KevinVandy merged commit 84dc3eb into main Mar 7, 2026
4 checks passed
@KevinVandy KevinVandy deleted the davidkpiano/fix-table-issue branch March 7, 2026 15:50
@github-actions github-actions bot mentioned this pull request Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants