Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions packages/solid-router/tests/useMatch.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,62 @@ describe('useMatch', () => {
})
})
})

test('route-scoped useParams should remain readable from async work created by the route during navigation away', async () => {
let releaseDelayedRead: () => void = () => {}
const delayedReadGate = new Promise<void>((resolve) => {
releaseDelayedRead = resolve
})
let delayedRead!: Promise<void>
let delayedError: unknown

const rootRoute = createRootRoute({
component: () => <Outlet />,
})
const postRoute = createRoute({
getParentRoute: () => rootRoute,
path: '/posts/$postId',
component: function PostComponent() {
const params = postRoute.useParams()

delayedRead = delayedReadGate.then(() => {
try {
params()
} catch (err) {
delayedError = err
}
})

return <h1>Post {params().postId}</h1>
},
})
const otherRoute = createRoute({
getParentRoute: () => rootRoute,
path: '/other',
component: () => <h1>OtherTitle</h1>,
})
const router = createRouter({
routeTree: rootRoute.addChildren([postRoute, otherRoute]),
history: createMemoryHistory({ initialEntries: ['/posts/one'] }),
})

render(() => <RouterProvider router={router} />)
expect(await screen.findByText('Post one')).toBeInTheDocument()

await router.navigate({ to: '/other' })
expect(await screen.findByText('OtherTitle')).toBeInTheDocument()

releaseDelayedRead()
await delayedRead

if (delayedError) {
throw new Error(
`Route-scoped useParams threw after navigation away: ${
delayedError instanceof Error
? delayedError.message
: String(delayedError)
}`,
)
}
})
})
Loading