fix(solid-router): restore MatchRoute reactivity by Sheraff · Pull Request #6911 · TanStack/router

Sheraff · 2026-03-12T22:30:50Z

Summary

restore reactive rendering in Solid MatchRoute so route changes do not leave render-prop or plain children stuck on the initial match result
move useMatchRoute option destructuring into the memoized scope so reactive to and params inputs are tracked correctly
add a regression test covering navigation updates and reactive params changes for both MatchRoute child forms

Testing

CI=1 NX_DAEMON=false pnpm nx run @tanstack/solid-router:test:unit --outputStyle=stream --skipRemoteCache
CI=1 NX_DAEMON=false pnpm nx run @tanstack/solid-router:test:types --outputStyle=stream --skipRemoteCache

Track MatchRoute options and child rendering inside Solid memos so navigation updates and reactive params cannot get stuck on the initial match result.

changeset-bot · 2026-03-12T22:30:59Z

⚠️ No Changeset found

Latest commit: c957c51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-12T22:31:00Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c011e641-fc0b-4edb-9300-5edc329dd8dc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch opencode/glowing-wizard

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

nx-cloud · 2026-03-12T22:31:23Z

View your CI Pipeline Execution ↗ for commit c957c51

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	9m 20s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	42s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-12 22:41:22 UTC

github-actions · 2026-03-12T22:33:47Z

Bundle Size Benchmarks

Commit: daa2ab9886f8
Measured at: 2026-03-12T22:33:06.756Z
Baseline source: history:daa2ab9886f8
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Raw	Brotli	Trend
`react-router.minimal`	87.98 KiB	+910 B (+1.02%)	277.30 KiB	76.41 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`react-router.full`	91.17 KiB	+1.09 KiB (+1.21%)	288.08 KiB	79.21 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`solid-router.minimal`	35.41 KiB	-1.02 KiB (-2.80%)	106.98 KiB	31.84 KiB	███████████▁
`solid-router.full`	39.82 KiB	-947 B (-2.27%)	120.26 KiB	35.69 KiB	███████████▁
`vue-router.minimal`	53.30 KiB	+1.01 KiB (+1.93%)	153.09 KiB	47.83 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`vue-router.full`	58.33 KiB	+1.25 KiB (+2.19%)	169.07 KiB	52.20 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`react-start.minimal`	100.63 KiB	+998 B (+0.98%)	316.51 KiB	87.08 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`react-start.full`	104.01 KiB	+1.04 KiB (+1.01%)	326.75 KiB	89.92 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`solid-start.minimal`	47.73 KiB	-1.02 KiB (-2.09%)	144.62 KiB	42.17 KiB	███████████▁
`solid-start.full`	53.32 KiB	-916 B (-1.65%)	160.81 KiB	46.96 KiB	███████████▁

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

pkg-pr-new · 2026-03-12T22:33:47Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6911

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6911

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6911

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6911

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6911

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6911

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6911

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6911

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6911

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6911

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6911

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6911

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6911

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6911

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6911

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6911

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6911

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6911

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6911

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6911

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6911

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6911

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6911

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6911

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6911

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6911

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6911

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6911

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6911

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6911

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6911

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6911

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6911

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6911

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6911

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6911

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6911

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6911

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6911

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6911

commit: ddcdc0e

codspeed-hq · 2026-03-12T22:49:25Z

Merging this PR will not alter performance

✅ 6 untouched benchmarks

_{Comparing opencode/glowing-wizard (c957c51) with refactor-signals (f3a0b42)}

fix(solid-router): restore MatchRoute reactivity

c957c51

Track MatchRoute options and child rendering inside Solid memos so navigation updates and reactive params cannot get stuck on the initial match result.

github-actions bot added the package: solid-router label Mar 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(solid-router): restore MatchRoute reactivity#6911

fix(solid-router): restore MatchRoute reactivity#6911
Sheraff wants to merge 1 commit intorefactor-signalsfrom
opencode/glowing-wizard

Sheraff commented Mar 12, 2026

Uh oh!

changeset-bot bot commented Mar 12, 2026

Uh oh!

coderabbitai bot commented Mar 12, 2026

Review skipped

Uh oh!

nx-cloud bot commented Mar 12, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

pkg-pr-new bot commented Mar 12, 2026

Uh oh!

codspeed-hq bot commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Sheraff commented Mar 12, 2026

Summary

Testing

Uh oh!

changeset-bot bot commented Mar 12, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 12, 2026

Review skipped

Uh oh!

nx-cloud bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2026

Bundle Size Benchmarks

Uh oh!

pkg-pr-new bot commented Mar 12, 2026

Uh oh!

codspeed-hq bot commented Mar 12, 2026

Merging this PR will not alter performance

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nx-cloud bot commented Mar 12, 2026 •

edited

Loading