Skip to content

chore: bump solid-refresh, fix deepEqual#6910

Merged
birkskyum merged 2 commits intosolid-router-v2-prefrom
upgrade-solid-refresh
Mar 12, 2026
Merged

chore: bump solid-refresh, fix deepEqual#6910
birkskyum merged 2 commits intosolid-router-v2-prefrom
upgrade-solid-refresh

Conversation

@brenelz
Copy link
Contributor

@brenelz brenelz commented Mar 12, 2026

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2026

🦋 Changeset detected

Latest commit: 484f531

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0535fb75-e8c1-439d-999a-b64a58a0be03

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upgrade-solid-refresh
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 12, 2026

View your CI Pipeline Execution ↗ for commit 484f531

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 49s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-12 23:14:30 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Bundle Size Benchmarks

  • Commit: 77bd44dee549
  • Measured at: 2026-03-12T23:13:19.538Z
  • Baseline source: history:77bd44dee549
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.09 KiB 0 B (0.00%) 274.11 KiB 75.68 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-router.full 90.08 KiB 0 B (0.00%) 284.36 KiB 78.32 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-router.minimal 38.00 KiB +1.58 KiB (+4.34%) 112.09 KiB 34.28 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-router.full 42.07 KiB +1.32 KiB (+3.24%) 124.85 KiB 37.88 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-router.minimal 52.29 KiB 0 B (0.00%) 149.34 KiB 47.01 KiB ▅▅▅▅▅▅▅▅▅▅▅
vue-router.full 57.08 KiB 0 B (0.00%) 164.85 KiB 51.27 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-start.minimal 99.66 KiB 0 B (0.00%) 313.26 KiB 86.22 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-start.full 102.97 KiB 0 B (0.00%) 322.99 KiB 89.07 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-start.minimal 53.55 KiB +4.80 KiB (+9.85%) 159.86 KiB 47.47 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.full 57.42 KiB +3.21 KiB (+5.92%) 171.16 KiB 50.74 KiB ▁▁▁▁▁▁▁▁▁▁▁█

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 12, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6910

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6910

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6910

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6910

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6910

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6910

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6910

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6910

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6910

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6910

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6910

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6910

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6910

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6910

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6910

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6910

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6910

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6910

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6910

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6910

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6910

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6910

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6910

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6910

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6910

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6910

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6910

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6910

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6910

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6910

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6910

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6910

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6910

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6910

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6910

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6910

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6910

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6910

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6910

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6910

commit: 7956ffc

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing upgrade-solid-refresh (484f531) with solid-router-v2-pre (cde6e61)1

Open in CodSpeed

Footnotes

  1. No successful run was found on solid-router-v2-pre (4ea461e) during the generation of this report, so 0b74c9f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@brenelz brenelz requested a review from birkskyum March 12, 2026 22:47
@birkskyum birkskyum force-pushed the upgrade-solid-refresh branch from c41fc4f to 484f531 Compare March 12, 2026 23:11
@birkskyum birkskyum merged commit 9ce7f97 into solid-router-v2-pre Mar 12, 2026
14 checks passed
@birkskyum birkskyum deleted the upgrade-solid-refresh branch March 12, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants