fix(examples): fix Netlify configuration #6461
Open
+456
−264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These examples state in their READMEs that they are configured for automatic deployment to Netlify, but this regressed when nitro was removed from tanstack core, and then regressed further in the `react/start-basic` example when the nitro v3 vite plugin was added (which is not compatible with Netlify's automatic build settings for TanStack Start).
Contributor
📝 WalkthroughWalkthroughThis PR adds Netlify deployment configuration across multiple React and Solid example projects. It introduces Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 36cc4af
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Fix all issues with AI agents
In `@examples/react/start-basic-rsc/vite.config.ts`:
- Line 6: The plugins array currently places netlify() after viteReact(),
causing incorrect SSR/build behavior; update the plugins ordering so netlify()
appears before viteReact() and after tanstackStart() — i.e., ensure the array
lists tanstackStart(), netlify(), viteReact() (reference the netlify(),
tanstackStart(), and viteReact() plugin calls to locate and reorder them).
In `@examples/react/start-basic/package.json`:
- Line 22: Update the dependency version for
"@netlify/vite-plugin-tanstack-start" in package.json: replace the non-existent
version string "^1.2.7" with the latest published release "^1.0.2" to match
available npm versions; after updating, regenerate your lockfile by running npm
install or yarn install so the lockfile reflects the change and verify the
example builds with the TanStack Start and Vite setup.
In `@examples/react/start-clerk-basic/package.json`:
- Line 25: The package.json dependency entry for
"@netlify/vite-plugin-tanstack-start" specifies a non-existent version "^1.2.7";
update the version specifier for the dependency
"@netlify/vite-plugin-tanstack-start" to a valid published version (for example
"^1.0.2") or remove the explicit version to allow using the latest per Netlify
guidance, then run npm/yarn install to verify resolution.
In `@examples/react/start-counter/vite.config.ts`:
- Around line 4-10: The plugin order in the Vite config is incorrect; move the
Netlify plugin so it sits between tanstackStart() and viteReact(): update the
plugins array from [tanstackStart(), viteReact(), netlify()] to
[tanstackStart(), netlify(), viteReact()] so the call sites tanstackStart(),
netlify(), and viteReact() appear in that sequence to match Netlify docs.
In `@examples/solid/start-basic-auth/package.json`:
- Line 25: Update the dependency version for
"@netlify/vite-plugin-tanstack-start" in package.json because "^1.2.7" is not
published; change the version constraint to a real release (for example "^1.0.2"
or the latest 1.0.x) and verify by running npm
info/@netlify/vite-plugin-tanstack-start or npm view to confirm the published
version before committing.
In `@examples/solid/start-basic/package.json`:
- Line 21: Replace the non-existent dependency version for
"@netlify/vite-plugin-tanstack-start" in package.json: change the version string
from "^1.2.7" to an existing published version such as "^1.0.2" (or "1.0.2"),
then update your lockfile by running your package manager (npm install / yarn
install / pnpm install) to ensure the correct package is installed.
In `@examples/solid/start-tailwind-v4/package.json`:
- Line 21: The dependency entry for "@netlify/vite-plugin-tanstack-start"
references a non-existent version (1.2.7); update the package.json dependency
for "@netlify/vite-plugin-tanstack-start" to a published version (e.g., 1.0.1)
that is compatible with Vite 7 and TanStack Start 1.154, then run your package
manager (npm/yarn/pnpm) to reinstall and verify the lockfile update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These examples all state in their READMEs that they are configured for automatic deployment to Netlify:
but this regressed when nitro was removed from tanstack core (1.132.0 I believe), and then regressed further several weeks ago in the
react/start-basicexample specifically when the nitro v3 vite plugin was added (which is not compatible with Netlify's automatic build settings for TanStack Start).Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.