fix(eslint-plugin-query): allow suspense queries combine deps#10642
fix(eslint-plugin-query): allow suspense queries combine deps#10642cyphercodes wants to merge 1 commit intoTanStack:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughA patch version bump adds a changeset fixing false positives in the ChangesESLint Rule Fix for useSuspenseQueries + combine
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 Changes
Fixes #10641.
no-unstable-depscombineexemption fromuseQueriestouseSuspenseQueries.useSuspenseQueriesresults can be used in React hook dependency arrays without a false positive.Local validation:
pnpm exec vitest run src/__tests__/no-unstable-deps.test.ts(frompackages/eslint-plugin-query)pnpm --filter @tanstack/eslint-plugin-query test:eslintpnpm --filter @tanstack/eslint-plugin-query test:typespnpm --filter @tanstack/eslint-plugin-query buildpnpm exec prettier --check packages/eslint-plugin-query/src/rules/no-unstable-deps/no-unstable-deps.rule.ts packages/eslint-plugin-query/src/__tests__/no-unstable-deps.test.ts .changeset/fuzzy-bobcats-remember.mdgit diff --check✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
Bug Fixes
no-unstable-depsESLint rule when using combined query results as dependencies.Tests