Skip to content

test(vue-query/useQueries): add test for outside scope warning in development mode#10240

Open
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:test/vue-query-useQueries-outside-scope-warning
Open

test(vue-query/useQueries): add test for outside scope warning in development mode#10240
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:test/vue-query-useQueries-outside-scope-warning

Conversation

@sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Mar 5, 2026

🎯 Changes

Add test for useQueries outside scope warning in development mode, covering useQueries.ts lines 254-259.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Tests
    • Added tests to validate warning behavior when using useQueries outside of proper execution scopes in development mode.

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2026

⚠️ No Changeset found

Latest commit: 99f2a2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cd44df53-07aa-458b-877b-6f888f1d64b8

📥 Commits

Reviewing files that changed from the base of the PR and between fe25edc and 99f2a2f.

📒 Files selected for processing (1)
  • packages/vue-query/src/__tests__/useQueries.test.ts

📝 Walkthrough

Walkthrough

Adds two test cases to the useQueries test suite that validate warning behavior in development mode. Both tests verify that a warning is emitted when useQueries is invoked outside a valid setup function or running effect scope.

Changes

Cohort / File(s) Summary
Test Coverage
packages/vue-query/src/__tests__/useQueries.test.ts
Added two development-mode tests verifying warning emission when useQueries is used outside valid execution context. Tests stub NODE_ENV, spy on console.warn, and assert exact warning messages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Tests hop into the code today,
Warning whispers find their way,
Outside scopes? We'll catch that call!
Development mode saves us all! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a test for the outside scope warning in useQueries' development mode.
Description check ✅ Passed The description follows the template structure with all required sections completed: Changes section describes the test addition, Checklist items are marked as completed, and Release Impact correctly identifies this as dev-only with no changeset needed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 5, 2026

View your CI Pipeline Execution ↗ for commit 99f2a2f

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 7s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-05 05:26:16 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 5, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10240

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10240

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10240

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10240

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10240

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10240

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10240

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10240

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10240

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10240

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10240

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10240

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10240

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10240

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10240

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10240

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10240

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10240

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10240

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10240

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10240

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10240

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10240

commit: 626c9d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant