Skip to content

fix: align intent TypeScript and ESLint setup with TanStack conventions#50

Merged
KyleAMathews merged 9 commits intoTanStack:mainfrom
WolfieLeader:fix/ts-and-eslint-errors
Mar 7, 2026
Merged

fix: align intent TypeScript and ESLint setup with TanStack conventions#50
KyleAMathews merged 9 commits intoTanStack:mainfrom
WolfieLeader:fix/ts-and-eslint-errors

Conversation

@WolfieLeader
Copy link
Contributor

🎯 Changes

Align the @tanstack/intent TypeScript and ESLint setup with the pattern used in other TanStack repos.

This PR:

  • includes packages/intent/tests in packages/intent/tsconfig.json
  • sets rootDir explicitly for the package TS project
  • brings eslint.config.js under root TS project coverage
  • cleans up the resulting lint/type issues in packages/intent/src and packages/intent/tests
  • knip.json added entry field since this is a CLI tool

Motivation:

  • remove editor and typed-ESLint project coverage errors
  • ensure diagnostics come from real TS project analysis instead of files falling outside tsconfig
  • keep the package aligned with broader TanStack conventions

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 7, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@50

commit: 219e628

@WolfieLeader
Copy link
Contributor Author

Is everything good?

@WolfieLeader
Copy link
Contributor Author

Let's go!

@WolfieLeader
Copy link
Contributor Author

I wanted to add something but I am waiting for approval. discoverSkills() is used twice we can create a single function that will be used.

@KyleAMathews KyleAMathews merged commit e2b0eec into TanStack:main Mar 7, 2026
3 checks passed
@KyleAMathews
Copy link
Collaborator

discoverSkills() is used twice we can create a single function that will be used.

Ah nice — yeah feel free to DRY that up in a new PR

@WolfieLeader
Copy link
Contributor Author

@KyleAMathews Thank you so much!

I will try to make it much more readable, is there a way to contact you to ask a bit of questions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants