fix(db): infer non-nullable return type from first arg in coalesce()#1342
Open
sleitor wants to merge 2 commits intoTanStack:mainfrom
Open
fix(db): infer non-nullable return type from first arg in coalesce()#1342sleitor wants to merge 2 commits intoTanStack:mainfrom
sleitor wants to merge 2 commits intoTanStack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 348a281 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
…n<any> Previously coalesce() always returned BasicExpression<any>, losing type information. Now it uses a generic to infer the non-nullable union of all argument types, matching the semantic of SQL COALESCE. Fixes TanStack#1341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
coalesce()was typed as(...args: Array<ExpressionLike>): BasicExpression<any>, which loses all type information when used in.select().Fixes #1341
Solution
Update the signature to infer
Tfrom the first argument so the return type isBasicExpression<NonNullable<ExtractType<T>>>. Subsequent args remain typed asExpressionLiketo support mixed-type calls likecoalesce(count(col), 0).Changes
packages/db/src/query/builder/functions.ts: Updatedcoalescesignature with genericTinferred from first argBasicExpression<any>toBasicExpression<string>