fix(ai): rename providerMetadata -> metadata in makeToolCall test helper#546
Conversation
Follow-up to #459, which renamed ToolCall.providerMetadata to ToolCall<TMetadata>.metadata across src/ but missed this test helper. tsc fails on main with TS2339 on tests/middlewares/fake-otel.ts, breaking pnpm test:ci and blocking the changesets release PR from being created.
|
View your CI Pipeline Execution ↗ for commit 8fcfe24
☁️ Nx Cloud last updated this comment at |
@tanstack/ai
@tanstack/ai-anthropic
@tanstack/ai-client
@tanstack/ai-code-mode
@tanstack/ai-code-mode-skills
@tanstack/ai-devtools-core
@tanstack/ai-elevenlabs
@tanstack/ai-event-client
@tanstack/ai-fal
@tanstack/ai-gemini
@tanstack/ai-grok
@tanstack/ai-groq
@tanstack/ai-isolate-cloudflare
@tanstack/ai-isolate-node
@tanstack/ai-isolate-quickjs
@tanstack/ai-ollama
@tanstack/ai-openai
@tanstack/ai-openrouter
@tanstack/ai-preact
@tanstack/ai-react
@tanstack/ai-react-ui
@tanstack/ai-solid
@tanstack/ai-solid-ui
@tanstack/ai-svelte
@tanstack/ai-utils
@tanstack/ai-vue
@tanstack/ai-vue-ui
@tanstack/openai-base
@tanstack/preact-ai-devtools
@tanstack/react-ai-devtools
@tanstack/solid-ai-devtools
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test utility ChangesMock Tool Call Builder Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Changeset Version Preview3 package(s) bumped directly, 31 bumped as dependents. 🟥 Major bumps
🟨 Minor bumps
🟩 Patch bumps
|
Summary
pnpm test:cionmain, which has been failing on@tanstack/ai:test:typessince fix(ai-gemini): read/write thoughtSignature at Part level for Gemini 3.x #459 was merged.ToolCall.providerMetadata→ToolCall<TMetadata>.metadataacrosssrc/, but missed themakeToolCalltest helper inpackages/typescript/ai/tests/middlewares/fake-otel.ts.tscnow errors withTS2339: Property 'providerMetadata' does not exist, which is what's blocking the Release workflow'sRun Testsstep and preventing the changesets release PR from being (re)created.Root cause
In #459 (87f305c),
ToolCall.providerMetadata: Record<string, unknown>becameToolCall<TMetadata>.metadata?: TMetadataeverywhere except themakeToolCalltest helper, whose conditional spread still references the old field name. The helper is typed against the currentToolCall, sotscrejects it.Test plan
pnpm --filter @tanstack/ai test:typespasses locallypnpm --filter @tanstack/ai test:libpasses locally (751 tests)pnpm --filter @tanstack/ai test:eslintcleanmaingoes green after merge, allowing the changesets release PR to be createdSummary by CodeRabbit