-
Notifications
You must be signed in to change notification settings - Fork 52
chore: storybook 10 #5675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: storybook 10 #5675
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
86efb73
chore: save
jmfrancois 51817b2
fix: it start and display !
jmfrancois 9697392
chore: save
jmfrancois 3f8e6f5
fix: dataviz
jmfrancois bd3a8cc
fix: build
jmfrancois 5a88b8b
chore: save
jmfrancois 5ac111d
fix: design docs
jmfrancois c7e5b1d
fix: many errors
jmfrancois aeb6178
chore: add changeset
jmfrancois 46ba8b6
docs: add missing changeset
jmfrancois bea41ff
fix: import of css and remove customize sass option
jmfrancois a026273
feat(eslint): only allow jsx into jsx files
jmfrancois 750b213
chore: cleanup storybook cmf plugin
jmfrancois 369a761
chore: save
jmfrancois 1beddde
fix: components stories
jmfrancois 9baca5f
fix: init storybook config
jmfrancois 21d4f5a
fix: make containers display things !
jmfrancois e32f620
fix: re-add action;
jmfrancois 248a711
fix: a few urls
jmfrancois 86e4279
fix: almost done
jmfrancois c5b8c18
fix: save
jmfrancois 2461053
chore(scripts): remove talend-scripts storybook commands
jmfrancois cc9c6dc
chore :update icons storybook
jmfrancois 64c5024
fix(icons): modernize the script
jmfrancois f15754f
fix: modernize icons
jmfrancois a72d935
fix: update faceted search storybook config
jmfrancois 9adad0b
fix: testdemo
jmfrancois 82f51f8
Merge branch 'master' into jmfrancois/chore/update-storybook
jmfrancois 1e9328c
chore: update CI
jmfrancois 78a5409
chore: update wf files
jmfrancois 7cf186c
fix: build
jmfrancois 49c6807
fix: build esm first
jmfrancois 155f33e
fix: add generate typeutils
jmfrancois 778658d
fix: lint
jmfrancois c80d17c
test: update
jmfrancois a4c2ff3
docs: update changelog
jmfrancois cbe4632
chore: update changelog
jmfrancois bf489cc
chore: update icon release changelog
jmfrancois fb78eb9
chore: remove webpack from icons build
jmfrancois cb7dccc
Potential fix for code scanning alert no. 2709: Shell command built f…
jmfrancois 24ab00d
docs: update changelog with breaking changes
jmfrancois 906ccf8
chore: rename the package
jmfrancois 980ae07
fix: use local icons
jmfrancois 0dd3f3c
fix: icon bundles
jmfrancois e0581c7
docs: update form to remove require
jmfrancois 92f9786
fix: integrate bootstrap-theme in storybook config
jmfrancois 2748cc1
Merge branch 'master' into jmfrancois/chore/update-storybook
jmfrancois d207b21
docs: fix latest story
jmfrancois 492f2d2
chore: update stories
jmfrancois e715eed
fix(Icons): filter
jmfrancois d8e7f16
fix: Modal and Forms
jmfrancois 641a8ba
test: update snap
jmfrancois 0c8e66f
fix: chromatic issue
franck-boncler2 73176da
fix: chromatic issue
franck-boncler2 3100e35
fix: padding in dialog
franck-boncler2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@talend/react-faceted-search': minor | ||
| '@talend/react-components': minor | ||
| '@talend/react-forms': minor | ||
| --- | ||
|
|
||
| feat: migrate forgotten file to jsx file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@talend/icons': major | ||
| --- | ||
|
|
||
| chore: refactor build to output more ESM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@talend/react-components': patch | ||
| --- | ||
|
|
||
| fix: add type function to all withTranslation exported component | ||
|
|
||
| The goal here is to make type inference of typescript happy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| --- | ||
| '@talend/scripts-core': major | ||
| --- | ||
|
|
||
| chore: remove storybook commands and integration | ||
|
|
||
| You should do the following to migrate: | ||
|
|
||
| in your package.json | ||
| ```diff | ||
|
|
||
| "scripts": { | ||
| - "start": "talend-scripts start" | ||
| + "start": "storybook dev" | ||
| - "build-storybook": "talend-scripts build-storybook" | ||
| + "build-storybook": "storybook build" | ||
| } | ||
|
|
||
| "dependencies": { | ||
| - "@talend/scripts-core": "^16.8.0", | ||
| + "@talend/scripts-core": "^17.0.0", | ||
|
|
||
| - "@storybook/addon-actions": "^7.6.21", | ||
| - "@storybook/.*": "^7.6.21", | ||
| + "@storybook/addon-a11y": "^10.1.11", | ||
| + "@storybook/addon-links": "^10.1.11", | ||
| + "@storybook/react": "^10.1.11", | ||
| + "@storybook/react-vite": "^10.1.11", | ||
| - "@talend/scripts-config-storybook-lib": "^5.8.0", | ||
| + "@talend/scripts-config-storybook-lib": "^6.0.0", | ||
| + "storybook": "^10.1.11" | ||
| } | ||
| ``` | ||
|
|
||
| Then ensure you have update your `.storybook/main.js` and `.storybook/preview` files like this: | ||
|
|
||
| - rename to main.mjs to use ESM | ||
| - keep main.ts if it was already in TS. | ||
|
|
||
| ```js | ||
| // .storybook/main.mjs | ||
| import { createMainConfig } from '@talend/scripts-config-storybook-lib/main'; | ||
|
|
||
| export default createMainConfig({}); | ||
| ``` | ||
|
|
||
| ```js | ||
| // .storybook/preview.mjs | ||
| import { createPreviewConfig } from '@talend/scripts-config-storybook-lib/main'; | ||
|
|
||
| const preview = createPreviewConfig({ | ||
| parameters: {}, | ||
| i18n: { | ||
| namespaces: [...tuiContainersNamespaces, ...tuiComponentsNamespaces, ...dsNamespaces], | ||
| remoteLocalesMap: { | ||
| 'tui-containers': | ||
| 'https://statics.cloud.talend.com/@talend/locales-tui-containers/9.1.3/locales/{{lng}}/{{ns}}.json', | ||
| 'tui-components': | ||
| 'https://statics.cloud.talend.com/@talend/locales-tui-components/16.0.1/locales/{{lng}}/{{ns}}.json', | ||
| 'design-system': | ||
| 'https://statics.cloud.talend.com/@talend/locales-design-system/7.15.1/locales/{{lng}}/{{ns}}.json', | ||
| }, | ||
| }, | ||
| cmf: { | ||
| modules: [cmfModule], | ||
| settings: settings, | ||
| }, | ||
| }); | ||
| ``` | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@talend/react-containers': patch | ||
| --- | ||
|
|
||
| fix: migrate SelectObject scss to css |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,9 @@ | ||
| --- | ||
| '@talend/react-faceted-search': major | ||
| '@talend/react-storybook-cmf': major | ||
| '@talend/react-cmf-router': major | ||
| '@talend/react-components': major | ||
| '@talend/react-containers': major | ||
| '@talend/react-forms': major | ||
| '@talend/react-a11y': major | ||
| '@talend/react-cmf': major | ||
| --- | ||
|
|
||
| No breaking in terms of API but may be some side effect in your config (like storybook) | ||
| No breaking in terms of API but may be some side effect in your config (like storybook) that can break your test or your build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@talend/react-cmf': patch | ||
| --- | ||
|
|
||
| fix: check if window is defined |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@talend/react-storybook-cmf': major | ||
| --- | ||
|
|
||
| feat: update to storybook 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@talend/scripts-config-storybook-lib': major | ||
| --- | ||
|
|
||
| feat: migrate to storybook 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@talend/storybook-docs': major | ||
| --- | ||
|
|
||
| feat: migrate to storybook 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@talend/eslint-config': major | ||
| --- | ||
|
|
||
| only allow jsx into jsx files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@talend/scripts-config-typescript': major | ||
| --- | ||
|
|
||
| feat: set moduleResolution to bundler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@talend/design-docs': minor | ||
| --- | ||
|
|
||
| feat: migrate scss to css |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@talend/react-components': patch | ||
| --- | ||
|
|
||
| fix: migrate Dialog.scss into css |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| import type { ComponentType, ReactNode } from 'react'; | ||
| import type { Store, Dispatch, AnyAction } from 'redux'; | ||
|
|
||
| export interface CMFContext { | ||
| store: Store; | ||
| registry: any; | ||
| [extra: string]: any; | ||
| } | ||
|
|
||
| export interface SagaProps { | ||
| saga: (...args: any[]) => any; | ||
| sagaAttributes?: any; | ||
| children?: ReactNode; | ||
| } | ||
|
|
||
| export const App: ComponentType<any>; | ||
| export const Dispatcher: ComponentType<any>; | ||
| export const ErrorBoundary: ComponentType<any>; | ||
| export const Inject: ComponentType<any>; | ||
| export const RegistryProvider: ComponentType<any>; | ||
| export const Saga: ComponentType<SagaProps>; | ||
| export const CmfRegisteredSaga: ComponentType<SagaProps>; | ||
|
|
||
| export const actions: any; | ||
| export const action: (...args: any[]) => AnyAction; | ||
| export const actionCreator: { | ||
| register: (name: string, creator: (...args: any[]) => AnyAction, context?: any) => void; | ||
| unregister: (name: string) => void; | ||
| get: (name: string) => (...args: any[]) => AnyAction; | ||
| [id: string]: any; | ||
| }; | ||
| export const bootstrap: (config?: any) => Promise<any>; | ||
| export const cmfConnect: ( | ||
| mapStateToProps?: any, | ||
| mapDispatchToProps?: any, | ||
| mergeProps?: any, | ||
| options?: any, | ||
| ) => (Component: ComponentType<any>) => ComponentType<any>; | ||
| export const cmfModule: any; | ||
| export const component: any; | ||
| export const componentState: any; | ||
| export const constants: any; | ||
| export const expression: any; | ||
| export const expressions: any; | ||
| export const localStorage: any; | ||
| export const matchPath: any; | ||
| export const middlewares: any; | ||
| export const onError: any; | ||
| export const reducers: any; | ||
| export const registry: any; | ||
| export const sagas: any; | ||
| export const selectors: any; | ||
| export const settings: any; | ||
| export const store: (...args: any[]) => Store; | ||
| export const mock: any; | ||
| export const useCMFContext: () => CMFContext; | ||
|
|
||
| export const getErrorMiddleware: any; | ||
| export const httpMiddleware: any; | ||
|
|
||
| declare const cmfDefault: { | ||
| action: typeof action; | ||
| actions: typeof actions; | ||
| actionCreator: typeof actionCreator; | ||
| bootstrap: typeof bootstrap; | ||
| component: typeof component; | ||
| connect: typeof cmfConnect; | ||
| constants: typeof constants; | ||
| CmfRegisteredSaga: typeof CmfRegisteredSaga; | ||
| expression: typeof expression; | ||
| expressions: typeof expressions; | ||
| middlewares: typeof middlewares; | ||
| module: typeof cmfModule; | ||
| onError: typeof onError; | ||
| registerInternals: (context?: any) => void; | ||
| registry: typeof registry; | ||
| router: { | ||
| matchPath: typeof matchPath; | ||
| }; | ||
| Saga: typeof Saga; | ||
| saga: typeof sagas; | ||
| sagas: typeof sagas; | ||
| selectors: typeof selectors; | ||
| settings: typeof settings; | ||
| localStorage: typeof localStorage; | ||
| }; | ||
|
|
||
| export default cmfDefault; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import { createMainConfig } from '@talend/scripts-config-storybook-lib/main'; | ||
|
|
||
| export default createMainConfig(); |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only true for a lib, an app would want to keep its start script as it is and update whatever the storybook app