Skip to content

chore(QTDI-2913): fix wrong condition #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
undx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(QTDI-2913): fix wrong condition #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...am/src/main/java/org/talend/sdk/component/runtime/beam/transformer/BeamIOTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,6 @@ private static BiConsumer<OutputStream, Object> doCreateSerializer() {
writeClass.invoke(oos, obj, false);
} else if (ObjectStreamClass.class.isInstance(obj)) {
writeClassDesc.invoke(oos, obj, false);
} else if (String.class.isInstance(obj)) {
writeClassDesc.invoke(oos, obj, false);
} else if (obj instanceof String) {
writeString.invoke(oos, obj, false);
} else if (obj.getClass().isArray()) {
Expand Down
12 changes: 12 additions & 0 deletions ...rc/test/java/org/talend/sdk/component/runtime/beam/transformer/BeamIOTransformerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,18 @@ void coder() {
});
}

@Test
void bypassReplaceSerializerHandlesString() {
// Ensures the custom serializer used by SerializationWrapper writes top-level String
// values via writeString instead of falling into the wrong writeClassDesc branch.
scenario((transformer, loader) -> {
final BeamIOTransformer.SerializationWrapper wrapper =
(BeamIOTransformer.SerializationWrapper) BeamIOTransformer.SerializationWrapper
.replace("hello", "test");
assertEquals("hello", wrapper.readResolve());
});
}

@Test
void coderSerialization() {
scenario((transformer, loader) -> {
Expand Down
Loading