fix(QTDI-2420): Change discover schema action order for input in TaCoKitGuessSchema by yyin-talend · Pull Request #1164 · Talend/component-runtime

yyin-talend · 2026-02-04T06:54:26Z

https://qlik-dev.atlassian.net/browse/QTDI-2420

sonar-eks · 2026-02-04T07:40:51Z

Quality Gate passed

Issues

Measures

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

ypiel-talend

I think the TCK documentation has to be reviewed too:
https://talend.github.io/component-runtime/main/latest/studio-schema.html#_guess_schema_action_selection

ozhelezniak-talend

okay, but it really good to just rewrite this part completely...

Copilot

Pull request overview

Updates schema discovery selection for DI input components to prioritize @DiscoverSchemaExtended before @DiscoverSchema, aligning runtime behavior with the QTDI-2420 expectation and updating the related Studio documentation.

Changes:

Reordered inferred action lookup to try schema_extended (DiscoverSchemaExtended) before schema (DiscoverSchema) when action is empty.
When action is explicitly provided, allow both schema_extended and schema types and prefer schema_extended.
Updated documentation to reflect the new action selection order for inputs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
documentation/src/main/antora/modules/ROOT/pages/studio-schema.adoc	Adjusts documented input action-selection order to prefer `@DiscoverSchemaExtended` before `@DiscoverSchema`.
component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java	Changes runtime action-selection order and selection criteria to prioritize and support both schema action types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

...-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java

documentation/src/main/antora/modules/ROOT/pages/studio-schema.adoc

ozhelezniak-talend · 2026-03-16T16:25:53Z

Could you check Copilot comments, some of them looks valid

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

ozhelezniak-talend

lgtm

Copilot

Pull request overview

Updates schema discovery selection to prefer @DiscoverSchemaExtended over @DiscoverSchema for input schema guessing in TaCoKitGuessSchema, and aligns (part of) the documentation with that updated selection order.

Changes:

Reordered input action lookup to try schema_extended before schema when inferring the action name from the dataset.
When an action name is explicitly provided, allow both schema and schema_extended and prefer schema_extended when both exist.
Updated the Studio schema documentation’s “For inputs” selection order accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
documentation/src/main/antora/modules/ROOT/pages/studio-schema.adoc	Updates documented action selection order for input schema discovery.
component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java	Adjusts runtime action selection to prefer `schema_extended` and support both action types for the same name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-20T13:33:05Z

...-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java

            actionRef = services
                    .stream()
                    .flatMap(s -> s.getActions().stream())
                    .filter(a -> a.getFamily().equals(family) && a.getAction().equals(action)
-                            && a.getType().equals(SCHEMA_TYPE))
+                            && (a.getType().equals(SCHEMA_EXTENDED_TYPE) || a.getType().equals(SCHEMA_TYPE)))
+                    // When both DiscoverSchemaExtended and DiscoverSchema exist for the same action name,
+                    // prefer the extended schema action by ordering it first.
+                    .sorted((action1, action2) -> {
+                        boolean action1IsExtended = action1.getType().equals(SCHEMA_EXTENDED_TYPE);
+                        boolean action2IsExtended = action2.getType().equals(SCHEMA_EXTENDED_TYPE);
+                        return Boolean.compare(!action1IsExtended, !action2IsExtended);
+                    })
                    .findFirst()
                    .orElseThrow(() -> new IllegalArgumentException(
-                            "No action " + family + "#" + SCHEMA_TYPE + "#" + action));
+                            "No action " + family + "#(" + SCHEMA_TYPE + " or " + SCHEMA_EXTENDED_TYPE + ")#"
+                                    + action));


New behavior changes action resolution to allow both schema and schema_extended when action is explicitly set and to prefer schema_extended when both exist. There are existing unit tests for TaCoKitGuessSchema, but none appear to cover the “both actions exist for the same name → pick extended” case. Adding a focused test would guard against regressions in this selection/ordering logic.

Copilot · 2026-03-20T13:33:06Z

documentation/src/main/antora/modules/ROOT/pages/studio-schema.adoc

 .. search an action of type `@DiscoverSchema`.
 . Execute a fake job with component to retrieve output schema.


In the “For inputs” action selection list, the last step says to “search an action of type @DiscoverSchema” (without matching the dataset name), but TaCoKitGuessSchema.guessSchemaThroughAction() doesn’t implement this fallback when action is empty (it returns false and falls back to the mock job). Update the documentation to reflect the actual behavior, or implement the documented fallback in code so the docs remain accurate.

Suggested change

.. search an action of type `@DiscoverSchema`.

. Execute a fake job with component to retrieve output schema.

. If no matching action is found, execute a fake job with the component to retrieve the output schema.

Copilot · 2026-03-20T13:33:06Z

...-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java

                    .orElse(null);
            if (actionRef == null) {
-                // let's try DiscoverSchemaExtended action name
+                // second find DiscoverSchema action name


This comment is grammatically unclear: “second find DiscoverSchema action name”. Consider rephrasing (e.g., “Then try the DiscoverSchema action name”) so it’s easier to follow when debugging action selection.

Suggested change

// second find DiscoverSchema action name

// Then try the DiscoverSchema action name.

Copilot · 2026-03-20T13:33:06Z

...-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java

+                    .sorted((action1, action2) -> {
+                        boolean action1IsExtended = action1.getType().equals(SCHEMA_EXTENDED_TYPE);
+                        boolean action2IsExtended = action2.getType().equals(SCHEMA_EXTENDED_TYPE);
+                        return Boolean.compare(!action1IsExtended, !action2IsExtended);
+                    })
                    .findFirst()


The stream uses sorted(...).findFirst() just to prefer schema_extended over schema. This sorts the entire candidate list (O(n log n)) even though you only need the best match. Consider replacing it with min(comparator) (or equivalent) to select the preferred action in a single pass and keep intent clearer.

Suggested change

.sorted((action1, action2) -> {

boolean action1IsExtended = action1.getType().equals(SCHEMA_EXTENDED_TYPE);

boolean action2IsExtended = action2.getType().equals(SCHEMA_EXTENDED_TYPE);

return Boolean.compare(!action1IsExtended, !action2IsExtended);

})

.findFirst()

.min((action1, action2) -> {

boolean action1IsExtended = action1.getType().equals(SCHEMA_EXTENDED_TYPE);

boolean action2IsExtended = action2.getType().equals(SCHEMA_EXTENDED_TYPE);

return Boolean.compare(!action1IsExtended, !action2IsExtended);

})

Change discover schema action order for input in TaCoKitGuessSchema

02fc4b2

yyin-talend requested a review from undx February 4, 2026 06:54

yyin-talend changed the title ~~Fix(QTDI-2420):Change discover schema action order for input in TaCoKitGuessSchema~~ fix(QTDI-2420):Change discover schema action order for input in TaCoKitGuessSchema Feb 4, 2026

undx previously approved these changes Feb 4, 2026

View reviewed changes

ypiel-talend reviewed Mar 9, 2026

View reviewed changes

ypiel-talend requested a review from undx March 9, 2026 09:18

feat(QTDI-2420): reflect change input discovery order

977a048

undx dismissed their stale review via 977a048 March 9, 2026 16:37

undx added 2 commits March 9, 2026 17:38

Merge branch 'master' into fix/QTDI-2420-DiscoverSchemaExtended

b1eca2e

feat(QTDI-2420): use extended prefered instead of just basic action

be418b9

undx requested a review from ozhelezniak-talend March 16, 2026 15:36

ozhelezniak-talend requested a review from Copilot March 16, 2026 16:16

Copilot started reviewing on behalf of ozhelezniak-talend March 16, 2026 16:17 View session

ozhelezniak-talend previously approved these changes Mar 16, 2026

View reviewed changes

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Potential fix for pull request finding

6745ba8

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

undx dismissed ozhelezniak-talend’s stale review via 6745ba8 March 16, 2026 16:27

undx and others added 2 commits March 16, 2026 17:28

Potential fix for pull request finding

7f1d806

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

aec9658

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

undx requested review from Copilot and ozhelezniak-talend March 20, 2026 13:29

Copilot started reviewing on behalf of undx March 20, 2026 13:29 View session

ozhelezniak-talend approved these changes Mar 20, 2026

View reviewed changes

ozhelezniak-talend changed the title ~~fix(QTDI-2420):Change discover schema action order for input in TaCoKitGuessSchema~~ fix(QTDI-2420): Change discover schema action order for input in TaCoKitGuessSchema Mar 20, 2026

Copilot AI reviewed Mar 20, 2026

View reviewed changes

		.. search an action of type `@DiscoverSchema`.
		. Execute a fake job with component to retrieve output schema.

	.. search an action of type `@DiscoverSchema`.
	. Execute a fake job with component to retrieve output schema.
	. If no matching action is found, execute a fake job with the component to retrieve the output schema.

	// second find DiscoverSchema action name
	// Then try the DiscoverSchema action name.

Conversation

yyin-talend commented Feb 4, 2026 • edited by undx Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonar-eks bot commented Feb 4, 2026

Quality Gate passed

Issues

Measures

Uh oh!

ypiel-talend left a comment

Choose a reason for hiding this comment

Uh oh!

ozhelezniak-talend left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ozhelezniak-talend commented Mar 16, 2026

Uh oh!

ozhelezniak-talend left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yyin-talend commented Feb 4, 2026 •

edited by undx

Loading