feat(QTDI-2134): dynamic dependencies

[undx]

https://qlik-dev.atlassian.net/browse/QTDI-2134

Related pull requests

• feat(QTDI-2134): dynamic dependencies #1143
• https://github.com/Talend/studio/pull/71

[sonar-eks]

Quality Gate failed

• 0.00% Coverage on New Code (is less than 80.00%)
• 14 New Issues (is greater than 0)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

[Copilot]

Pull request overview

This PR implements dynamic dependencies support for the Talend component runtime framework. The changes enable components to declare and resolve dependencies dynamically at runtime based on configuration, which is crucial for scenarios where dependencies cannot be determined at compile time (e.g., JDBC drivers selected by users).

Changes:

• Renamed DynamicDependenciesServiceConfiguration annotation to DynamicDependenciesConfiguration for improved clarity and consistency
• Added support for reading dynamic dependencies from TALEND-INF/dynamic-dependencies.properties files
• Enhanced runtime classpath resolution with support for manifest-based classpath entries and filtering
• Introduced parent resource filtering mechanism to control which resources are loaded from parent classloaders
• Improved nested jar discovery and error handling in component auto-discovery

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/config/DynamicDependenciesConf.java	Updated to use renamed annotation
documentation/src/main/antora/modules/ROOT/pages/_partials/generated_configuration-types.adoc	Updated documentation for renamed annotation
container/container-core/src/test/java/org/talend/sdk/component/dependencies/maven/MvnDependencyListLocalRepositoryResolverTest.java	Added test for dynamic dependencies resolution
container/container-core/src/test/java/org/talend/sdk/component/classloader/ConfigurableClassLoaderTest.java	Added test for parent resource filtering functionality
container/container-core/src/test/java/org/talend/sdk/component/ContainerManagerTest.java	Added tests for manifest classpath parsing
container/container-core/src/main/java/org/talend/sdk/component/dependencies/maven/MvnDependencyListLocalRepositoryResolver.java	Implements dynamic dependencies lookup and merging with standard dependencies
container/container-core/src/main/java/org/talend/sdk/component/container/ContainerManager.java	Added runtime classpath capture, manifest parsing, and improved logging for diagnostics
container/container-core/src/main/java/org/talend/sdk/component/container/Container.java	Updated to pass resource filter to ConfigurableClassLoader
container/container-core/src/main/java/org/talend/sdk/component/classloader/ConfigurableClassLoader.java	Added resource filtering support and exposed nested URLs via getURLs()
component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ComponentManagerTest.java	Updated test expectations for nested repository handling
component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java	Added resource filtering, improved nested jar discovery, and enhanced error handling
component-api/src/main/java/org/talend/sdk/component/api/configuration/type/DynamicDependenciesConfiguration.java	Renamed from DynamicDependenciesServiceConfiguration with updated documentation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

component-api/src/main/java/org/talend/sdk/component/api/configuration/type/DynamicDependenciesConfiguration.java:31

• This change renames a public API annotation type from DynamicDependenciesServiceConfiguration to DynamicDependenciesConfiguration. Since this is in component-api, it is a source-breaking change for any external components using the old annotation. Consider keeping a deprecated DynamicDependenciesServiceConfiguration annotation as an alias (delegating to the new @ConfigurationType) for at least one major/minor cycle to preserve backward compatibility.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ozhelezniak-talend]

left comments

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

component-api/src/main/java/org/talend/sdk/component/api/configuration/type/DynamicDependenciesConfiguration.java:31

• Renaming the public annotation from DynamicDependenciesServiceConfiguration to DynamicDependenciesConfiguration (and changing the @ConfigurationType value) is a breaking change for existing components and any tooling relying on the previous type id (dynamicDependenciesServiceConfiguration). If backward compatibility is needed, consider keeping the old annotation as @Deprecated (delegating to / aliasing the new one) and/or supporting both configuration type identifiers during a transition period.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

component-api/src/main/java/org/talend/sdk/component/api/configuration/type/DynamicDependenciesConfiguration.java:31

• DynamicDependenciesServiceConfiguration was renamed to DynamicDependenciesConfiguration and the @ConfigurationType value changed. Since this is in component-api, this is a source/binary breaking change for any consumers using the old annotation or metadata type string. Consider keeping a deprecated compatibility annotation (old name + old @ConfigurationType), delegating/mapping it to the new one, or otherwise providing a migration path.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

component-api/src/main/java/org/talend/sdk/component/api/configuration/type/DynamicDependenciesConfiguration.java:31

• Renaming the public annotation and changing the @ConfigurationType key is a breaking change for any existing components/tools relying on DynamicDependenciesServiceConfiguration / dynamicDependenciesServiceConfiguration. Consider keeping a deprecated compatibility alias (old annotation name + old configurationtype string) delegating to the new one, and update remaining references in the repo (e.g. talend-component-maven-plugin/src/it/web/test/tck-component-details-api-test/tck_component_details_api_test.json still asserts the old configurationtype::type).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

getResource()/getResources() now apply shouldLoadFromParent(...) (including resourcesFilter) when delegating to the parent, but getResourceAsStream() still falls back to getParent().getResource(name) without applying the same check. This makes it possible to bypass the new parent resource filtering simply by using getResourceAsStream. Consider applying the same shouldLoadFromParent(url) (and/or isNestedDependencyResource) check before returning the parent stream.