Skip to content

[TASK] Disable some Type Perfect PHPStan rules#2134

Merged
AnReiter merged 1 commit into
mainfrom
task/no-narrow-paramreturn
May 18, 2026
Merged

[TASK] Disable some Type Perfect PHPStan rules#2134
AnReiter merged 1 commit into
mainfrom
task/no-narrow-paramreturn

Conversation

@oliverklee
Copy link
Copy Markdown
Contributor

The narrow_param and narrow_return rules don't work well with Extbase generics and with nullable properties. Hence they create false positives.

Disable them.

The `narrow_param` and `narrow_return` rules don't work well
with Extbase generics and with nullable properties. Hence
they create false positives.

Disable them.
@oliverklee oliverklee added this to the 4.1.0 milestone May 18, 2026
@oliverklee oliverklee requested a review from AnReiter May 18, 2026 10:31
@oliverklee oliverklee self-assigned this May 18, 2026
@oliverklee oliverklee added bug Something isn't working cleanup labels May 18, 2026
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26028091048

Warning

No base build found for commit 995b371 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 96.678%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 301
Covered Lines: 291
Line Coverage: 96.68%
Coverage Strength: 3.98 hits per line

💛 - Coveralls

@AnReiter AnReiter merged commit 4e5975a into main May 18, 2026
45 checks passed
@AnReiter AnReiter deleted the task/no-narrow-paramreturn branch May 18, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants