[TASK] Prioritize composer.json over environment variable for extension key #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on key Change extension key resolution order: 1. CLI argument (highest priority) 2. composer.json [extra][typo3/cms][extension-key] (recommended) 3. TYPO3_EXTENSION_KEY environment variable (deprecated, BC only) Using the environment variable now triggers a deprecation warning. Benefits: - Single source of truth in version-controlled composer.json - Solves CI log masking issue where secrets are redacted, causing unhelpful error messages like 'Could not publish extension ***' Resolves: #xxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the extension key resolution order to prioritize
composer.jsonover theTYPO3_EXTENSION_KEYenvironment variable.New precedence:
composer.jsonat[extra][typo3/cms][extension-key](recommended)TYPO3_EXTENSION_KEYenvironment variable (deprecated, BC only)Changes
TYPO3_EXTENSION_KEY(new setups should use composer.json)Why?
composer.jsonalongside other extension metadataTYPO3_EXTENSION_KEYis configured as a secret, error messages get masked (e.g."Could not publish extension ***"), hiding valuable information in error reportsBackwards Compatibility
The environment variable still works for existing setups but triggers a deprecation warning encouraging migration to
composer.json.Resolves: #88